Skip to content

Fix copy/paste error and duplicate config #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 23, 2025
Merged

Fix copy/paste error and duplicate config #4406

merged 8 commits into from
Jun 23, 2025

Conversation

nathan-contino
Copy link
Contributor

Issue raised internally.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jun 23, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 23, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 7ef289f
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/6859bc0c45200a0008c87230
😎 Deploy Preview https://deploy-preview-4406--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 58 (🟢 up 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

JessamyT
JessamyT approved these changes Jun 23, 2025
View reviewed changes
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Otterverse
Otterverse requested changes Jun 23, 2025
View reviewed changes
@nathan-contino
Copy link
Contributor Author

@Otterverse thanks for the feedback. I still have some questions, and a couple of suggestions -- can you take another look? Thank you.

@nathan-contino
Copy link
Contributor Author

@Otterverse back to you again!

@nathan-contino
Copy link
Contributor Author

@Otterverse Implemented the fixes, thanks for the background! When we add documentation for bluetooth provisioning, we can update the verbiage if bluetooth provisioning happens at the same time as hotspotting.

JessamyT
JessamyT reviewed Jun 23, 2025
View reviewed changes
@nathan-contino @JessamyT
Update docs/manage/reference/viam-agent/_index.md
c9d733d 
Co-authored-by: Jessamy Taylor <75634662+JessamyT@users.noreply.github.com>
nathan-contino
nathan-contino commented Jun 23, 2025
View reviewed changes
Otterverse
Otterverse approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathan-contino nathan-contino merged commit d29e196 into main Jun 23, 2025
12 of 13 checks passed
@nathan-contino nathan-contino deleted the nathan-contino-patch-1 branch June 23, 2025 20:44
@github-actions GitHub Actions
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessamyT JessamyT

@Otterverse Otterverse

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathan-contino @Otterverse @JessamyT @viambot