feat: Support adding @YdbType annotation to method parameters #173
Description
To cover the following (and all similar) case:
interface MyRepository extends ListCrudRepository<MyEntity, String> {
@Query(
"""
SELECT <....>
<....>
LIMIT :limit
"""
)
List<MyEntity> findWithLimit(@Param("limit") long limit);
}The inferred limit parameter type here is Int64, while YDB requires it to be exaclty UInt64.
There are other cases where implicit type conversion fails. So a way to control this behavior would be great. An existing @YdbType annotation seems like a good solution.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
mipo256 commentedon Feb 17, 2025
@zdazzy Existing
YdbMappingJdbcConvertershould solve this. This customJdbcConverteris applied on both named and positional parameters.Have you extended the
AbstractYdbJdbcConfiguration?zdazzy commentedon Feb 20, 2025
@mipo256 The annotation is currently only applicable to fields. Placing it on method parameter will result in a compilation error.
The issue has nothing to do with configuration.
mipo256 commentedon Feb 21, 2025
Yes, I got the general idea of what you're trying to do.
CC: @KirillKurdyukov please, add the
pending-designtag for the issuemipo256 commentedon Feb 21, 2025
The first top-level review of the problem unravels the following approach.
We can specify the custom
RepositoryFactoryBeanSupportin the@EnableJdbcRepositories, extended fromJdbcRepositoryFactoryBeanlikely. We need it to override the creation of theJdbcRepositoryFactorychild that has it's ownQueryLookupStrategydefined. And here, we can construct our ownQueryMethodwith our own implementation ofgetParameters().That would solve the problem. However, there are a couple of caveats.
JdbcQueryLookupStrategythat is native to Spring Data JDBC, likeCreateIfNotFoundQueryLookupStrategy, which is used by default, is not a public API. Therefore, we would have to extendRelationalQueryLookupStrategyand duplicate some code from the original source tree.So, we need to think about it more deeply.
CC: @KirillKurdyukov
mipo256 commentedon Feb 21, 2025
Related spring-projects/spring-data-relational#1998
mipo256 commentedon Mar 14, 2025
UPDATE: After discussion with Spring Data team: The corresponding Spring Data JDBC change would be introduced in 4.0.x major release. When this will be done, we'll be able to implement this feature.
CC: @zdazzy @KirillKurdyukov
KirillKurdyukov commentedon Mar 17, 2025
Thanks Misha!
ydb-platformGH-173 Added custom YdbRepositoryFactory infrastructure
1 remaining item