Skip to content

Made SchemeShard tests robust to changing of PathIds #19992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Made SchemeShard tests robust to changing of PathIds #19992

merged 1 commit into from
Jun 23, 2025

Conversation

n00bcracker
Copy link
Collaborator

Many SchemeShard tests rely on PathIds of created object so after changing the number of initial paths tests become failed.
Have to fix it, getting a PathId during tests.

@n00bcracker n00bcracker marked this pull request as ready for review June 20, 2025 15:57
@n00bcracker n00bcracker requested a review from a team as a code owner June 20, 2025 15:57
@github-actions GitHub Actions
Copy link

🟢 2025-06-20 15:57:30 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

⚪ 2025-06-20 16:00:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4163ed5 has started.
⚪ 2025-06-20 16:00:30 UTC Artifacts will be uploaded here
⚪ 2025-06-20 16:03:04 UTC ya make is running...
🟢 2025-06-20 16:21:02 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3073 3071 0 0 0 2

🟢 2025-06-20 16:21:26 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

⚪ 2025-06-20 16:01:29 UTC Pre-commit check linux-x86_64-release-asan for 4163ed5 has started.
⚪ 2025-06-20 16:03:45 UTC Artifacts will be uploaded here
⚪ 2025-06-20 16:07:16 UTC ya make is running...
🟡 2025-06-20 16:27:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2069 1994 0 8 65 2

⚪ 2025-06-20 16:28:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 16:41:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
375 (only retried tests) 372 0 2 0 1

⚪ 2025-06-20 16:41:21 UTC ya make is running... (failed tests rerun, try 3)
⚫ 2025-06-20 16:42:05 UTC Check cancelled

ijon
ijon previously approved these changes Jun 20, 2025
View reviewed changes
@n00bcracker n00bcracker force-pushed the make_schemeshard_tests_robust branch from 2dcd33e to 3fca50a Compare June 20, 2025 16:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

⚪ 2025-06-20 16:44:15 UTC Pre-commit check linux-x86_64-release-asan for 9c0ad66 has started.
⚪ 2025-06-20 16:44:35 UTC Artifacts will be uploaded here
⚪ 2025-06-20 16:47:42 UTC ya make is running...
🟡 2025-06-20 17:21:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2069 2063 0 2 0 4

⚪ 2025-06-20 17:22:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 17:35:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 201 0 2 0 1

⚪ 2025-06-20 17:35:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-20 17:47:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 201 0 2 0 1

🟢 2025-06-20 17:48:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

⚪ 2025-06-20 16:45:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c0ad66 has started.
⚪ 2025-06-20 16:45:44 UTC Artifacts will be uploaded here
⚪ 2025-06-20 16:48:18 UTC ya make is running...
🟢 2025-06-20 17:28:30 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3073 3072 0 0 0 1

🟢 2025-06-20 17:28:53 UTC Build successful.

@n00bcracker n00bcracker merged commit 0046f6c into ydb-platform:main Jun 23, 2025
12 checks passed
@n00bcracker n00bcracker deleted the make_schemeshard_tests_robust branch June 23, 2025 07:12
@n00bcracker n00bcracker linked an issue Jun 24, 2025 that may be closed by this pull request
Make YDB tests robust to SchemeShard initialization #19986
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make YDB tests robust to SchemeShard initialization
2 participants
@n00bcracker @ijon