Skip to content

Remove encrypted deserializer state from logs #20015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Remove logging all the state, because encrypted file deserializer state contains secret key

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner June 22, 2025 19:42
Copy link

🟢 2025-06-22 19:42:31 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 22, 2025

2025-06-22 19:43:32 UTC Pre-commit check linux-x86_64-release-asan for 62d5962 has started.
2025-06-22 19:43:44 UTC Artifacts will be uploaded here
2025-06-22 19:47:10 UTC ya make is running...
🟡 2025-06-22 21:45:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15689 15365 0 105 189 30

2025-06-22 21:47:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-22 22:18:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1605 (only retried tests) 1368 0 54 160 23

2025-06-22 22:18:42 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-22 22:52:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1575 (only retried tests) 1314 0 58 177 26

🟢 2025-06-22 22:52:44 UTC Build successful.
🟢 2025-06-22 22:53:16 UTC ydbd size 3.9 GiB changed* by +464 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecb9d76 merge: 62d5962 diff diff %
ydbd size 4 185 150 376 Bytes 4 185 150 840 Bytes +464 Bytes +0.000%
ydbd stripped size 1 450 983 384 Bytes 1 450 983 512 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 22, 2025

2025-06-22 19:45:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 62d5962 has started.
2025-06-22 19:46:01 UTC Artifacts will be uploaded here
2025-06-22 19:49:27 UTC ya make is running...
🟡 2025-06-22 21:18:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37944 35227 0 5 2665 47

2025-06-22 21:21:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-22 21:34:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
674 (only retried tests) 636 0 1 4 33

2025-06-22 21:34:57 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-22 21:45:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
380 (only retried tests) 338 0 0 3 39

🟢 2025-06-22 21:46:05 UTC Build successful.
🟢 2025-06-22 21:46:27 UTC ydbd size 2.2 GiB changed* by +352 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: ecb9d76 merge: 62d5962 diff diff %
ydbd size 2 378 944 072 Bytes 2 378 944 424 Bytes +352 Bytes +0.000%
ydbd stripped size 498 353 192 Bytes 498 353 256 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

CyberROFL
CyberROFL previously approved these changes Jun 24, 2025
Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 20:40:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c6fe5a has started.
2025-06-25 20:40:21 UTC Artifacts will be uploaded here
2025-06-25 20:44:09 UTC ya make is running...
🟡 2025-06-25 21:56:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38350 35625 0 5 2681 39

2025-06-25 22:00:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-25 22:11:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
356 (only retried tests) 320 0 6 2 28

2025-06-25 22:11:35 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-25 22:22:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
300 (only retried tests) 272 0 0 2 26

🟢 2025-06-25 22:22:20 UTC Build successful.
🟢 2025-06-25 22:22:37 UTC ydbd size 2.2 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 94e006b merge: 9c6fe5a diff diff %
ydbd size 2 382 783 848 Bytes 2 382 795 856 Bytes +11.7 KiB +0.001%
ydbd stripped size 498 851 368 Bytes 498 851 624 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 25, 2025

2025-06-25 09:32:03 UTC Pre-commit check linux-x86_64-release-asan for 9c6fe5a has started.
2025-06-25 09:32:14 UTC Artifacts will be uploaded here
2025-06-25 09:35:59 UTC ya make is running...
🟡 2025-06-25 12:08:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16033 15593 0 125 283 32

🟢 2025-06-25 12:10:07 UTC Build successful.
🟢 2025-06-25 12:10:36 UTC ydbd size 3.9 GiB changed* by +15.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 94e006b merge: 9c6fe5a diff diff %
ydbd size 4 191 905 632 Bytes 4 191 921 896 Bytes +15.9 KiB +0.000%
ydbd stripped size 1 453 130 520 Bytes 1 453 131 608 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis enabled auto-merge (squash) June 25, 2025 12:29
@UgnineSirdis UgnineSirdis merged commit e543b14 into ydb-platform:main Jun 25, 2025
19 of 21 checks passed
@UgnineSirdis UgnineSirdis deleted the remove-deserializer-state-from-logs branch June 26, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants