Support State Storage reconfiguration via Ring Groups in Scheme Board Subscribers #20018

jepett0 · 2025-06-22T22:58:15Z

Changelog entry

Changelog category

Not for changelog (changelog entry is not required)

Description for reviewers

Epic:

👑 Bridge mode support in Scheme Board #19748

Issue:

Bridge Mode in SB: support State Storage reconfiguration in subscribers #19825

This PR is based on another one. The base PR was merged before the current one and so the final commit of this PR contains only the subscriber changes.

github-actions · 2025-06-22T23:01:08Z

🟢 2025-06-24 14:09:47 UTC The validation of the Pull Request description is successful.

ydb/core/base/statestorage.h

ydb/tests/stress/reconfig_state_storage_workload/tests/test_scheme_board_workload.py

ydb/core/tx/scheme_board/subscriber.cpp

ydb/tests/stress/reconfig_state_storage_workload/tests/test_scheme_board_workload.py

- we haven't taken into account the previous acks, so the quorum was essentially never reached in case of multiple ring groups

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

There is a dependency loop that I don't want to fix

… Subscribers

…heme_board_workload.py Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

github-actions · 2025-06-23T15:06:13Z

⚪ 2025-06-23 15:06:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7f0ea23 has started.
⚪ 2025-06-23 15:06:24 UTC Artifacts will be uploaded here
⚪ 2025-06-23 15:09:43 UTC ya make is running...
🟡 2025-06-23 16:21:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
29469	28071	0	8	1357	33

⚪ 2025-06-23 16:23:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-23 16:35:33 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
629 (only retried tests)	596	0	0	2	31

🟢 2025-06-23 16:35:42 UTC Build successful.
🟢 2025-06-23 16:36:00 UTC ydbd size 2.2 GiB changed* by +58.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `67e7808`	merge: `7f0ea23`	diff	diff %
ydbd size	2 379 785 608 Bytes	2 379 845 632 Bytes	+58.6 KiB	+0.003%
ydbd stripped size	498 508 424 Bytes	498 522 184 Bytes	+13.4 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-06-23T15:06:26Z

⚪ 2025-06-23 15:06:25 UTC Pre-commit check linux-x86_64-release-asan for 7f0ea23 has started.
⚪ 2025-06-23 15:06:37 UTC Artifacts will be uploaded here
⚪ 2025-06-23 15:09:58 UTC ya make is running...
🟡 2025-06-23 17:02:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14227	13936	0	74	192	25

⚪ 2025-06-23 17:04:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-23 17:36:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1582 (only retried tests)	1293	0	58	202	29

⚪ 2025-06-23 17:36:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-23 18:12:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1596 (only retried tests)	1337	0	55	180	24

🟢 2025-06-23 18:12:27 UTC Build successful.
🟡 2025-06-23 18:12:59 UTC ydbd size 3.9 GiB changed* by +127.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `67e7808`	merge: `7f0ea23`	diff	diff %
ydbd size	4 186 755 728 Bytes	4 186 886 312 Bytes	+127.5 KiB	+0.003%
ydbd stripped size	1 451 392 216 Bytes	1 451 438 552 Bytes	+45.2 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions bot added the not-for-changelog label Jun 22, 2025

This comment was marked as outdated.

Sign in to view

jepett0 marked this pull request as ready for review June 23, 2025 06:21

jepett0 requested a review from a team as a code owner June 23, 2025 06:21

github-actions bot added not-for-changelog and removed not-for-changelog labels Jun 23, 2025

jepett0 requested review from CyberROFL, Evgenik2 and alexvru June 23, 2025 06:22

jepett0 linked an issue Jun 23, 2025 that may be closed by this pull request

Bridge Mode in SB: support State Storage reconfiguration in subscribers #19825

Closed

CyberROFL reviewed Jun 23, 2025

View reviewed changes

ydb/core/base/statestorage.h Outdated Show resolved Hide resolved

ydb/tests/stress/reconfig_state_storage_workload/tests/test_scheme_board_workload.py Outdated Show resolved Hide resolved

ydb/core/tx/scheme_board/subscriber.cpp Show resolved Hide resolved

Evgenik2 requested changes Jun 23, 2025

View reviewed changes

ydb/core/tx/scheme_board/subscriber.cpp Show resolved Hide resolved

ydb/core/tx/scheme_board/subscriber.cpp Show resolved Hide resolved

ydb/tests/stress/reconfig_state_storage_workload/tests/test_scheme_board_workload.py Outdated Show resolved Hide resolved

jepett0 and others added 7 commits June 23, 2025 14:27

Ignore DISCONNECTED ring groups when checking quorum + bugfix

d75b33a

- we haven't taken into account the previous acks, so the quorum was essentially never reached in case of multiple ring groups

silence VS code compilation warning

2a3d290

tests

80dc58d

Update ydb/core/tx/scheme_board/populator.cpp

7d7330c

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

remove unnecessary changes

6d7b47e

review fixes

a3c7847

reuse prod functions in unit tests

66f7bab

This comment was marked as outdated.

Sign in to view

jepett0 force-pushed the 2DC.subscriber_reconfiguration.1 branch from c9fc63f to 87af445 Compare June 23, 2025 14:36

This comment was marked as outdated.

Sign in to view

jepett0 requested review from CyberROFL and Evgenik2 June 23, 2025 14:46

This comment was marked as outdated.

Sign in to view

fix linker errors

4b13af5

jepett0 force-pushed the 2DC.subscriber_reconfiguration.1 branch from 8b80a86 to 6ee4cf9 Compare June 23, 2025 14:50

This comment was marked as outdated.

Sign in to view

jepett0 and others added 5 commits June 23, 2025 15:02

don't deduplicate actorsys tests

cdbdb14

There is a dependency loop that I don't want to fix

Support State Storage reconfiguration via Ring Groups in Scheme Board…

cb28d27

… Subscribers

Update ydb/tests/stress/reconfig_state_storage_workload/tests/test_sc…

a4d23c7

…heme_board_workload.py Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

better workload test naming + no OLAP flag

f4d20bc

remove all traces of switch replica event

c39d24a

jepett0 force-pushed the 2DC.subscriber_reconfiguration.1 branch from 6ee4cf9 to c39d24a Compare June 23, 2025 15:02

Evgenik2 approved these changes Jun 23, 2025

View reviewed changes

alexvru approved these changes Jun 23, 2025

View reviewed changes

CyberROFL approved these changes Jun 24, 2025

View reviewed changes

github-actions bot added not-for-changelog and removed not-for-changelog labels Jun 24, 2025

jepett0 merged commit ddcd276 into ydb-platform:main Jun 24, 2025
16 checks passed

github-actions bot added not-for-changelog and removed not-for-changelog labels Jun 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support State Storage reconfiguration via Ring Groups in Scheme Board Subscribers #20018

Support State Storage reconfiguration via Ring Groups in Scheme Board Subscribers #20018

Uh oh!

jepett0 commented Jun 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 22, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Support State Storage reconfiguration via Ring Groups in Scheme Board Subscribers #20018

Support State Storage reconfiguration via Ring Groups in Scheme Board Subscribers #20018

Uh oh!

Conversation

jepett0 commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Description for reviewers

Uh oh!

github-actions bot commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jepett0 commented Jun 22, 2025 •

edited

Loading

github-actions bot commented Jun 22, 2025 •

edited

Loading

github-actions bot commented Jun 23, 2025 •

edited

Loading

github-actions bot commented Jun 23, 2025 •

edited

Loading