Skip to content

Support bidirectional assimilation #20021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jun 23, 2025

Changelog entry

Support bidirectional assimilation

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch allows running assimilation in reverse order for online VDisk with read-write support to make assimilation predictable. Intended to use for syncing piles in Bridge mode.

Copy link

🟢 2025-06-23 08:25:13 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 23, 2025

2025-06-23 08:27:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9e55b07 has started.
2025-06-23 08:27:19 UTC Artifacts will be uploaded here
2025-06-23 08:31:06 UTC ya make is running...
🟡 2025-06-23 10:23:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38269 35542 0 3 2676 48

2025-06-23 10:27:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-23 10:37:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
763 (only retried tests) 731 0 0 0 32

🟢 2025-06-23 10:37:58 UTC Build successful.
🟡 2025-06-23 10:38:18 UTC ydbd size 2.2 GiB changed* by +169.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e45a3f0 merge: 9e55b07 diff diff %
ydbd size 2 379 036 816 Bytes 2 379 210 520 Bytes +169.6 KiB +0.007%
ydbd stripped size 498 376 520 Bytes 498 403 784 Bytes +26.6 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 23, 2025

2025-06-23 08:27:23 UTC Pre-commit check linux-x86_64-release-asan for 9e55b07 has started.
2025-06-23 08:27:36 UTC Artifacts will be uploaded here
2025-06-23 08:31:18 UTC ya make is running...
🟡 2025-06-23 10:55:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15971 15609 0 88 248 26

2025-06-23 10:56:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-23 11:33:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1739 (only retried tests) 1481 0 52 181 25

2025-06-23 11:34:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-23 12:04:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1448 (only retried tests) 1205 0 47 169 27

🟢 2025-06-23 12:05:12 UTC Build successful.
🟡 2025-06-23 12:05:47 UTC ydbd size 3.9 GiB changed* by +233.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e45a3f0 merge: 9e55b07 diff diff %
ydbd size 4 185 311 944 Bytes 4 185 550 896 Bytes +233.4 KiB +0.006%
ydbd stripped size 1 451 045 560 Bytes 1 451 086 584 Bytes +40.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) June 23, 2025 12:14
@alexvru alexvru merged commit a9e4bdd into ydb-platform:main Jun 23, 2025
13 checks passed
@alexvru alexvru deleted the 2dc/support-bidirectional-assimilation branch June 23, 2025 12:36
@alexvru alexvru self-assigned this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants