Skip to content

Add more details to vector index rejection errors (#19455) #20060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vitalif
Copy link
Collaborator

@vitalif vitalif commented Jun 23, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@vitalif vitalif requested a review from a team as a code owner June 23, 2025 15:02
@vitalif vitalif linked an issue Jun 23, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jun 23, 2025

2025-06-23 15:04:35 UTC Pre-commit check linux-x86_64-release-asan for 36990f8 has started.
2025-06-23 15:04:58 UTC Artifacts will be uploaded here
2025-06-23 15:08:48 UTC ya make is running...
🟡 2025-06-23 16:44:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13780 13449 0 117 188 26

2025-06-23 16:46:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-23 17:22:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1754 (only retried tests) 1486 0 69 173 26

2025-06-23 17:22:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-23 17:58:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1678 (only retried tests) 1426 0 56 171 25

🟢 2025-06-23 17:58:28 UTC Build successful.
🟢 2025-06-23 17:58:59 UTC ydbd size 3.9 GiB changed* by +43.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 67e7808 merge: 36990f8 diff diff %
ydbd size 4 186 755 728 Bytes 4 186 799 928 Bytes +43.2 KiB +0.001%
ydbd stripped size 1 451 392 216 Bytes 1 451 405 144 Bytes +12.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-06-23 15:05:16 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 23, 2025

2025-06-23 15:05:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 36990f8 has started.
2025-06-23 15:06:08 UTC Artifacts will be uploaded here
2025-06-23 15:09:22 UTC ya make is running...
🟡 2025-06-23 16:09:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28792 27403 0 6 1348 35

2025-06-23 16:12:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-23 16:23:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
498 (only retried tests) 470 0 0 0 28

🟢 2025-06-23 16:23:20 UTC Build successful.
🟢 2025-06-23 16:23:40 UTC ydbd size 2.2 GiB changed* by +9.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 67e7808 merge: 36990f8 diff diff %
ydbd size 2 379 785 608 Bytes 2 379 794 864 Bytes +9.0 KiB +0.000%
ydbd stripped size 498 508 424 Bytes 498 511 176 Bytes +2.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitalif vitalif requested a review from kunga June 23, 2025 17:28
@vitalif vitalif force-pushed the vector-index-reject-detail-message branch from 5a04f7a to 956b503 Compare June 24, 2025 17:32
Copy link

github-actions bot commented Jun 24, 2025

2025-06-24 17:35:39 UTC Pre-commit check linux-x86_64-release-asan for ca3a797 has started.
2025-06-24 17:35:50 UTC Artifacts will be uploaded here
2025-06-24 17:39:11 UTC ya make is running...
🟡 2025-06-24 19:23:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13811 13343 0 129 306 33

🟢 2025-06-24 19:25:07 UTC Build successful.
🟢 2025-06-24 19:25:35 UTC ydbd size 3.9 GiB changed* by +39.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04c388e merge: ca3a797 diff diff %
ydbd size 4 191 869 120 Bytes 4 191 909 928 Bytes +39.9 KiB +0.001%
ydbd stripped size 1 453 112 632 Bytes 1 453 124 536 Bytes +11.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 24, 2025

2025-06-24 17:36:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for ca3a797 has started.
2025-06-24 17:36:28 UTC Artifacts will be uploaded here
2025-06-24 17:39:42 UTC ya make is running...
🟢 2025-06-24 18:45:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28840 27452 0 0 1354 34

🟢 2025-06-24 18:47:43 UTC Build successful.
🟢 2025-06-24 18:48:03 UTC ydbd size 2.2 GiB changed* by +9.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04c388e merge: ca3a797 diff diff %
ydbd size 2 382 766 744 Bytes 2 382 776 456 Bytes +9.5 KiB +0.000%
ydbd stripped size 498 847 400 Bytes 498 850 216 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitalif vitalif requested a review from kunga June 25, 2025 07:44
@vitalif
Copy link
Collaborator Author

vitalif commented Jun 25, 2025

Позеленело, лайкните плиз =)

@vitalif vitalif requested a review from gridnevvvit June 25, 2025 07:44
@vitalif vitalif merged commit 5fd1504 into ydb-platform:main Jun 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InnerProductSimilarity vector index
3 participants