Skip to content

The PQ tablet did not receive a TEvReadSet #20074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

Changes from #20020

There was a T1 transaction in the EXECUTED queue. She is waiting for the signal to continue working. The T2 transaction was queued and its state was saved to disk. Transaction T1 was running at that moment. As a result, the T2 transaction continued to run when its state had not yet been saved to disk. She sent TEvReadSetAck to her "colleagues" and they deleted the T2 transaction. If the tablet restarts at this moment, the T2 transaction will be in the PLANNED state and will never receive a TEvReadSet from "colleagues".

Before continuing to execute a transaction, you need to make sure that its state is saved to disk. Added a check.

Changelog category

  • Bugfix

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner June 23, 2025 21:14
Copy link

github-actions bot commented Jun 23, 2025

2025-06-23 21:16:15 UTC Pre-commit check for 56d89e1 has started.
2025-06-23 21:19:36 UTC Build linux-x86_64-release-asan is running...
🟢 2025-06-23 22:07:43 UTC Build successful.
2025-06-23 22:07:58 UTC Tests are running...
🔴 2025-06-24 00:31:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14422 14272 0 53 53 44

🟢 2025-06-24 00:32:21 UTC ydbd size 5.6 GiB changed* by -4.4 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: bd9fda7 merge: 56d89e1 diff diff %
ydbd size 6 028 319 288 Bytes 6 028 314 736 Bytes -4.4 KiB -0.000%
ydbd stripped size 1 508 586 944 Bytes 1 508 586 880 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 23, 2025

2025-06-23 21:32:02 UTC Pre-commit check for 56d89e1 has started.
2025-06-23 21:35:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-06-23 22:43:30 UTC Build successful.
2025-06-23 22:43:47 UTC Tests are running...
🔴 2025-06-24 00:58:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75725 62222 0 29 13435 39

🟢 2025-06-24 00:59:12 UTC ydbd size 8.3 GiB changed* by +15.2 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: bd9fda7 merge: 56d89e1 diff diff %
ydbd size 8 899 287 504 Bytes 8 899 303 072 Bytes +15.2 KiB +0.000%
ydbd stripped size 485 046 920 Bytes 485 046 984 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 6a32a47 into ydb-platform:stable-24-4 Jun 24, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants