Add stress & compatibility tests for Node Broker Delta Protocol #20934
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds stress and compatibility testing for the Node Broker Delta Protocol by introducing a new stress test workload and a suite of compatibility tests covering mixed clusters, version restarts, and rolling upgrades.
- Added
TestDeltaProtocolstress test class to exercise delta protocol under load - Updated
ya.maketo include the new compatibility test file - Introduced
test_node_broker_delta_protocol.pywith fixtures for mixed cluster, restart, and rolling upgrade scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/tests/stress/node_broker/tests/test_workload.py | Added TestDeltaProtocol class to run stress workloads with delta protocol enabled |
| ydb/tests/compatibility/ya.make | Registered test_node_broker_delta_protocol.py in TEST_SRCS |
| ydb/tests/compatibility/test_node_broker_delta_protocol.py | New compatibility tests for Node Broker Delta Protocol across various upgrade paths |
Comments suppressed due to low confidence (2)
ydb/tests/stress/node_broker/tests/test_workload.py:35
- [nitpick] The class name
TestDeltaProtocolis quite generic. Consider renaming it toTestNodeBrokerDeltaProtocolWorkloadto clearly indicate its purpose and align with other test naming.
class TestDeltaProtocol(object):
ydb/tests/compatibility/test_node_broker_delta_protocol.py:14
- Initializing
next_portto 0 will attempt node registration on port 0, which is reserved. Consider starting from a valid port range or deriving a free port dynamically to avoid invalid registrations.
self.next_port = 0
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
pixcc
force-pushed
the
stress-compatibility-tests
branch
from
d28836b to
2af67be
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
pixcc
force-pushed
the
stress-compatibility-tests
branch
from
2b88009 to
e3d9613
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
pixcc
force-pushed
the
stress-compatibility-tests
branch
from
f7aa768 to
e908d03
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog category
Description for reviewers
Этот PR добавляет стресс тесты и тесты совместимости для дельта протокола в Node Broker #11064.
TestDeltaProtocolдля проверки дельта протокола под нагрузкойtest_node_broker_delta_protocol.pyс тестами со смешанным кластером, перезапуском и rolling обновлением. Тесты не работают с версиями младше 25-1 из-за проблем с применением динамического конфига в тестовом окружении.