Skip to content

Fix release checkout #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Fix release checkout #3

merged 3 commits into from
Apr 8, 2025

Conversation

atteggiani
Copy link
Collaborator

@atteggiani atteggiani commented Apr 8, 2025

This PR attempts to fix the error produced within the release workflow.
The error should be related to this issue.

This PR implements the following changes:

  • Removed a condition within the tag deletion step to run it even if there is a failure wihtin the 'Check release tag' job (like in the error above)
  • Removed 'fetch-tags' when not needed and added 'ref: ...' to avoid errors in the actions/checkout action

@atteggiani atteggiani self-assigned this Apr 8, 2025
@atteggiani atteggiani requested a review from jo-basevi April 8, 2025 04:29
jo-basevi
jo-basevi previously approved these changes Apr 8, 2025
Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me

Copy link

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@atteggiani atteggiani force-pushed the davide/fix-release-checkout branch from e3300bd to 2f242fb Compare April 8, 2025 04:49
@atteggiani atteggiani merged commit 3ba32e8 into main Apr 8, 2025
1 check passed
@atteggiani atteggiani deleted the davide/fix-release-checkout branch April 8, 2025 04:49
@atteggiani
Copy link
Collaborator Author

Thank you @jo-basevi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants