Skip to content

chore(testing): validate requirements lockfiles with a github action #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 26, 2023

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 26, 2023

This change adds a github action that fails when a run of scripts/compile-and-prune-test-requirements leaves a dirty git tree, indicating that requirements lockfiles need to be generated or updated to match riotfile changes on the branch in question.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • PR description includes explicit acknowledgement/acceptance of the performance implications of this PR as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@emmettbutler emmettbutler requested a review from a team as a code owner April 26, 2023 14:32
@emmettbutler emmettbutler marked this pull request as draft April 26, 2023 14:32
@emmettbutler emmettbutler changed the title skeletal lockfiles check action chore(testing): validate requirements lockfiles with a github action Apr 26, 2023
@emmettbutler
Copy link
Collaborator Author

This is failing due to actions/checkout#363

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 26, 2023
@emmettbutler emmettbutler marked this pull request as ready for review April 26, 2023 18:41
@emmettbutler emmettbutler enabled auto-merge (squash) April 26, 2023 18:46
@emmettbutler emmettbutler merged commit a9f4c02 into 1.x Apr 26, 2023
@emmettbutler emmettbutler deleted the emmett.butler/locks-check branch April 26, 2023 19:18
@github-actions github-actions bot added this to the v1.14.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants