-
Notifications
You must be signed in to change notification settings - Fork 25
github: shallow-clone for actionlint and markdown check jobs #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: shallow-clone for actionlint and markdown check jobs #75
Conversation
For GitHub Actions that invoke setuptools-scm, we need the full Git history in order to get the proper versioning values from "git describe". For GitHub Actions that do not invoke setuptools-scm, we do not need the full Git history, so we can speed up those clone operations with shallow clones.
Reviewer's Guide by SourceryThis pull request modifies the GitHub Actions workflows for No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ktdreyer - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to the workflow files explaining why
fetch-depth: 0
was removed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
(sourcery-ai's statement is misleading: |
@ktdreyer thanks for the feedback on Sourcery. We are testing its effectiveness for PR review process. |
For GitHub Actions that invoke setuptools-scm, we need the full Git history in order to get the proper versioning values from "git describe". For GitHub Actions that do not invoke setuptools-scm, we do not need the full Git history, so we can speed up those clone operations with shallow clones.
For GitHub Actions that invoke
setuptools-scm
, we need the full Git history in order to get the proper versioning values fromgit describe
(actions/checkout#249).For GitHub Actions that do not invoke
setuptools-scm
, we do not need the full Git history, so we can speed up those clone operations with shallow clones.Summary by Sourcery
CI: