-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
bugSomething isn't workingSomething isn't workinggha-runner-scale-setRelated to the gha-runner-scale-set modeRelated to the gha-runner-scale-set modeneeds triageRequires review from the maintainersRequires review from the maintainers
Description
Checks
- I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
- I am using charts that are officially provided
Controller Version
0.11.0
Deployment Method
Helm
Checks
- This isn't a question or user support case (For Q&A and community support, go to Discussions).
- I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
To Reproduce
1. Add values for `template.spec.resources` in the gha-runner-scale-set Helm chart values
Describe the bug
Reopen #3943 as it is not actually fixed.
0.11.0 now allows resources
on the spec object, but it is not being passed onto the actual pods.
template:
spec:
resources:
requests:
cpu: "1000m"
memory: "1000Mi"
limits:
cpu: "2000m"
memory: "8000Mi"
$ kubectl -n arc-runners get pod cicd-pipelines-x2bqb-runner-48pn2 -o yaml | yq .spec.resources
null
Describe the expected behavior
The final runner pods should have a resource limit on the pods.
Additional Context
template:
spec:
resources:
requests:
cpu: "1000m"
memory: "1000Mi"
limits:
cpu: "2000m"
memory: "8000Mi"
Controller Logs
N/A
Runner Pod Logs
N/A
FearlessHyena, pdunnavant, danielatjumo, ryanbeales, lbarratt and 1 more
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggha-runner-scale-setRelated to the gha-runner-scale-set modeRelated to the gha-runner-scale-set modeneeds triageRequires review from the maintainersRequires review from the maintainers