Skip to content

Runner Template does not support pod resources (k8s 1.32+) #4034

@AngellusMortis

Description

@AngellusMortis

Checks

Controller Version

0.11.0

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Add values for `template.spec.resources` in the gha-runner-scale-set Helm chart values

Describe the bug

Reopen #3943 as it is not actually fixed.

0.11.0 now allows resources on the spec object, but it is not being passed onto the actual pods.

        template:
          spec:
            resources:
              requests:
                cpu: "1000m"
                memory: "1000Mi"
              limits:
                cpu: "2000m"
                memory: "8000Mi"
$ kubectl -n arc-runners get pod cicd-pipelines-x2bqb-runner-48pn2 -o yaml | yq .spec.resources
null

Describe the expected behavior

The final runner pods should have a resource limit on the pods.

Additional Context

template:
          spec:
            resources:
              requests:
                cpu: "1000m"
                memory: "1000Mi"
              limits:
                cpu: "2000m"
                memory: "8000Mi"

Controller Logs

N/A

Runner Pod Logs

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggha-runner-scale-setRelated to the gha-runner-scale-set modeneeds triageRequires review from the maintainers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions