Skip to content

Remove custom proxy functionality #134

New issue
New issue
Open
#143
Open
Remove custom proxy functionality#134
#143
Labels
featureNew feature or request
@gr2m

Description

@gr2m
gr2m
opened on May 1, 2024 · edited by gr2m
Contributor

Looks like Undici added native proxy support, so we may be able to remove the custom proxy support we added in #102.

create-github-app-token/lib/request.js

Lines 15 to 16 in 3cef845

// Native support for proxies in Undici is under consideration: https://github.com/nodejs/undici/issues/1650
// Until then, we need to use a custom fetch function to add proxy support.

Originally posted by @parkerbxyz in #132 (comment)

Activity

gr2m
added
featureNew feature or request
good first issueGood for newcomers
on May 1, 2024
parkerbxyz
linked a pull request that will close this issuefix: remove custom proxy handling #143on Jun 13, 2024
parkerbxyz
linked a pull request that will close this issue on Jun 13, 2024
parkerbxyz
removed
good first issueGood for newcomers
on Dec 20, 2024
parkerbxyz

parkerbxyz commented on Dec 20, 2024

@parkerbxyz
parkerbxyz
on Dec 20, 2024
Contributor

This depends on nodejs/node#43187. We may need to wait until that is resolved to finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @gr2m@parkerbxyz

      Issue actions
        Remove custom proxy functionality · Issue #134 · actions/create-github-app-token