Skip to content

Sync-labels should not remove an unspecified label #741

@OJFord

Description

@OJFord

Description:
I think that even with sync-labels: true, a label which is not defined in labeler.yml at all should not be removed.

Justification:
Some labels might be applied by other means, such as non-labeler workflows marking a PR as 'deployed' for example, which have no file or branch based (or any static/declarative) way of describing when they should exist.

If a label is not even defined according to paths etc., then it should not be removed by labeler - we should assume it has some other source.

If people want labeler to be an absolute source of truth for allowed labels, then an ignore key or similar would do - i.e. to define a list of allowed labels which aren't synchronised.

Are you willing to submit a PR?

Willing but not that familiar.

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions