Skip to content

Include Node.js version in cache key #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clintonb opened this issue Dec 14, 2024 · 2 comments · May be fixed by #1172
Open

Include Node.js version in cache key #1171

clintonb opened this issue Dec 14, 2024 · 2 comments · May be fixed by #1172
Labels
feature request New feature or request to improve the current logic

Comments

@clintonb
Copy link

Description:
The Node.js version should be included in the cache key. The major version number, (e.g., 22 in 22.12) should be used to avoid unnecessary invalidation when upgrading to patch or minor versions.

This is similar to #1008.

Justification:
Some dependencies need to be rebuilt for specific Node versions. Reusing the cache for an older version results in dependency installation failures.

Are you willing to submit a PR?
Yes.
@clintonb clintonb added feature request New feature or request to improve the current logic needs triage labels Dec 14, 2024
@clintonb clintonb linked a pull request Dec 14, 2024 that will close this issue
Open
2 tasks
@gowridurgad
Copy link
Contributor

Hello @clintonb ,
Thank you for this feature request. We will investigate it and get back to you as soon as we have some feedback.


@tpoisseau
Copy link

Any new on this issue ?
In monorepo with packages to test with different Node.js, applications not all with the same Node.js version, the actual generated key lead to dependencies which need to be rebuilt each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Node version to cache key voriteam/setup-node
4 participants
@clintonb @tpoisseau @gowridurgad and others