Skip to content

Avoid persisting credentials in CI/CD GitHub workflow #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Apr 25, 2025

Description of Change

Avoid persisting credentials in CI/CD GitHub workflow

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Credential persistence through GitHub Actions artifacts #1337
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Apr 25, 2025
@jakob-keller jakob-keller self-assigned this Apr 25, 2025
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (750b860) to head (0dc9de3).
Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          67       67           
  Lines        6559     6559           
=======================================
  Hits         5958     5958           
  Misses        601      601           
Flag Coverage Δ
unittests 90.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller linked an issue Apr 25, 2025 that may be closed by this pull request
@jakob-keller jakob-keller enabled auto-merge April 25, 2025 09:53
@jakob-keller jakob-keller requested a review from webknjaz April 25, 2025 09:54
@jakob-keller jakob-keller added this pull request to the merge queue Apr 25, 2025
Merged via the queue into aio-libs:master with commit a116cf6 Apr 25, 2025
74 of 78 checks passed
@jakob-keller jakob-keller deleted the github-checkout-fix branch April 25, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential persistence through GitHub Actions artifacts
2 participants