Add linter and formatter config #36
Conversation
|
Is github action disabled? Perhaps we have a policy of not using it? |
| with: | ||
| node-version: '16' | ||
| - name: Install Yarn | ||
| run: npm install -g yarn |
There was a problem hiding this comment.
when you use actions/checkout i think already yarn install process should be done.
maybe can you play around first by setting on: manual ?
I will ask to add you this org so I think you will be able to do so. just wait a moment
There was a problem hiding this comment.
I think I need to install yarn itself since the repository does not contain the yarn bin after checking out, is this correct?
I was verifying using act locally and was unable to use yarn in actions/setup-node@v3, so I am writing this based on this comment.
I should have written a comment because it's hard to understand.
This reverts commit f826b3f.
|
The lint outputs errors, but does not format the source itself to prevent conflicts. |
|
@hourglasshoro The github action seems to be working. Good job.
Do you mean to make this one a separate PR? If so, I am going to approve. |
|
I wanted to say that we will not be formatting the existing code, as it looks like quite a lot of modifications in the PR here! So I won't be issuing any additional PRs myself. I hope you don't mind that this PR CI is failing. If it seems looks good, I'd like to merge it. |
|
Understood! Thanks for the clarification! |
object
spec