Skip to content

ci: update workflows #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

ci: update workflows #59

merged 1 commit into from
Mar 23, 2025

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Mar 12, 2025

Last PR, I promise!

This PR:

  • Removes Git credentials after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script; see related GitHub security post and related actions/checkout issue
  • Declares the minimum permissions for the workflows to run at the workflow level, following principle of least privilege; see related GitHub security post
  • Set check-latest to true, so that the actions/setup-node will check it is using the latest minor or hotfix Node version and use that instead of its cached version, this stops an issue like with 22.5.0 that introduced a regression and actions were still using that instead of 22.5.1
  • Updates automerge job to check if the user triggering job is dependabot (same as what Fastify repos do)
  • Adds --ignore-scripts arg to npm install calls, preventing any potentially harmful lifecycle scripts that may have snuck in

@kibertoad kibertoad merged commit 0f1b25d into kibertoad:main Mar 23, 2025
3 checks passed
@Fdawgs Fdawgs deleted the ci/updates branch March 23, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants