-
-
Notifications
You must be signed in to change notification settings - Fork 43
Test - automatic CS fix + commit (in a PR from forked repo) #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@localheinz any idea why this works with a branch of the same repo in #1097, but not a remote branch? 🤔 This check should be green and a commit should be done |
You should add pull_request_target to the action trigger |
I tried, as you can see in the latest checks down below... 🤔 Maybe @stefanzweifel can help us 😄 |
👋 The php-cs-fixer runs fail, as the "Test/ PHP 8.0" run fails first: https://github.com/sonata-project/dev-kit/runs/1154581328#step:10:4 |
Hey, thanks for reaching out 👋
In this PR #1097 PHP 8-0 was failing too 🤔 |
AFAIK @localheinz is working on ergebnis/playground#230, too, but in this case he is fixing a local branch instead of a pull request branch from the outside repository 🤔 |
@stefanzweifel, now the PHP 8.0 build is green, but the others are still failing :( |
It seems GitHub can't clone this repo anymore: https://github.com/sonata-project/dev-kit/pull/1098/checks?check_run_id=1186863006#step:3:38 There's an open issue on the |
@stefanzweifel I added:
|
@OskarStark Thanks! I still have no good evidence why the checkout in the linter runs fails. I think it could be related that the run is triggered from a forked repository. 🤔
In Maybe you could give it a go by removing the |
Thanks for the feedback 🙏
Sure, I did, lets see... |
Nothing... 😞 |
Interesting.
I've just tagged a new version of git-auto-commit with adds a The README of git-auto-commit has recently been updated to point these issues with forks out. Actions like this which run a linter/fixer should probably run on a (But I understand that it would be great if it would work in a PR) |
I try, thanks 👍
Well I agree here, but it makes diffs harder to read, creates comments by people who doesn't know this + if you revert something ... its not so clean IMHO. |
Lets see if a PR receives an automatic CS fix