-
Notifications
You must be signed in to change notification settings - Fork 386
github-ci: add more cleanup for running WS #5987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
316ad39
to
0373a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helped me a lot. Thanks!
Typo: gitub → github. |
Does not it fix the whole problem? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside minor tweaks.
0373a9d
to
34389fe
Compare
Found that 'actions/checkout' does not remove all temporary files from previous runs in submodules [1], it runs only 'git clean --xffd' [2]: libgcov profiling error:/home/ubuntu/actions-runner/_work/tarantool/tarantool/src/lib/small/CMakeFiles/small.dir/small/small_class.c.gcda:overwriting an existing profile data with a different timestamp To avoid of it added: git submodules foreach --recursive 'git clean -xffd' to 'actions/environment' which is run after each 'actions/checkout'. Part of #5986 [1]: https://github.com/tarantool/tarantool/runs/2318244478?check_suite_focus=true#step:5:4012 [2]: actions/checkout#358
34389fe
to
9e54497
Compare
Seems not, I've found how to reproduce it locally. It is possible that we need some cleanup instructions for such situations, but I would suggest left the issue opened to discuss it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avtikhon, thanks for the fix! LGTM.
Pushed as 2.8.0-233-g57ab8c2e7, 2.7.1-193-g7513575e4, 2.6.2-187-ge327bd48a, 1.10.9-118-ge7d88cf11. |
gitub-ci: add more cleanup for running WS
Found that 'actions/checkout' does not remove all temporary files from
previous runs in submodules 1, it runs only 'git clean -xffd' 2:
To avoid of it added:
to 'actions/environment' which is run after each 'actions/checkout'.
Part of #5986