Skip to content

github-ci: add more cleanup for running WS #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

avtikhon
Copy link
Contributor

@avtikhon avtikhon commented Apr 13, 2021

gitub-ci: add more cleanup for running WS

Found that 'actions/checkout' does not remove all temporary files from
previous runs in submodules 1, it runs only 'git clean -xffd' 2:

  libgcov profiling error:/home/ubuntu/actions-runner/_work/tarantool/tarantool/src/lib/small/CMakeFiles/small.dir/small/small_class.c.gcda:overwriting an existing profile data with a different timestamp

To avoid of it added:

  git submodules foreach --recursive 'git clean -xffd'

to 'actions/environment' which is run after each 'actions/checkout'.

Part of #5986

@avtikhon avtikhon force-pushed the avtikhon/github-ci-clean-checkout branch 2 times, most recently from 316ad39 to 0373a9d Compare April 13, 2021 10:34
Copy link
Contributor

@cyrillos cyrillos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helped me a lot. Thanks!

@Totktonada
Copy link
Member

Typo: gitub → github.

@Totktonada
Copy link
Member

Part of #5986

Does not it fix the whole problem?

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside minor tweaks.

@avtikhon avtikhon force-pushed the avtikhon/github-ci-clean-checkout branch from 0373a9d to 34389fe Compare April 13, 2021 16:10
@avtikhon avtikhon changed the title gitub-ci: add more cleanup for running WS github-ci: add more cleanup for running WS Apr 13, 2021
Found that 'actions/checkout' does not remove all temporary files from
previous runs in submodules [1], it runs only 'git clean --xffd' [2]:

  libgcov profiling error:/home/ubuntu/actions-runner/_work/tarantool/tarantool/src/lib/small/CMakeFiles/small.dir/small/small_class.c.gcda:overwriting an existing profile data with a different timestamp

To avoid of it added:

  git submodules foreach --recursive 'git clean -xffd'

to 'actions/environment' which is run after each 'actions/checkout'.

Part of #5986

[1]: https://github.com/tarantool/tarantool/runs/2318244478?check_suite_focus=true#step:5:4012
[2]: actions/checkout#358
@avtikhon avtikhon force-pushed the avtikhon/github-ci-clean-checkout branch from 34389fe to 9e54497 Compare April 13, 2021 16:12
@avtikhon
Copy link
Contributor Author

Part of #5986

Does not it fix the whole problem?

Seems not, I've found how to reproduce it locally. It is possible that we need some cleanup instructions for such situations, but I would suggest left the issue opened to discuss it.

Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avtikhon, thanks for the fix! LGTM.

@Totktonada Totktonada merged commit 57ab8c2 into master Apr 14, 2021
@Totktonada Totktonada deleted the avtikhon/github-ci-clean-checkout branch April 14, 2021 16:39
@Totktonada
Copy link
Member

Pushed as 2.8.0-233-g57ab8c2e7, 2.7.1-193-g7513575e4, 2.6.2-187-ge327bd48a, 1.10.9-118-ge7d88cf11.

@avtikhon avtikhon added the teamQ label Apr 14, 2021
@avtikhon avtikhon self-assigned this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants