-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support private mirrors #1240
Conversation
the failures dont seem related to this change are they? |
Hello @marco-ippolito, Thank you for your pull request! We are currently reviewing it. To resolve the check failures, could you please rebase your branch with the main branch and push the changes. |
@aparnajyothi-y thanks, rebased |
@aparnajyothi-y change the message to |
248ba43
to
40509ec
Compare
I wonder if we can merge this |
Hello @marco-ippolito, With the latest commit, the log message now correctly displays the mirror URL when provided, which is the expected behavior. However, in the default fallback scenario (when no mirror URL is provided), the log message currently shows: "Falling back to download directly from." Instead, it should remain as it was previously, showing: "Falling back to download directly from Node." |
@aparnajyothi-y thanks I have updated the code |
Hello @marco-ippolito, With the latest commit, the log message still showing: "Falling back to download directly from" Instead, it should remain as it was previously, showing: "Falling back to download directly from Node" |
@aparnajyothi-y amended |
Fixes: #1150
Fixes: #730