Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support private mirrors #1240

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Conversation

marco-ippolito
Copy link
Contributor

Fixes: #1150
Fixes: #730

@marco-ippolito
Copy link
Contributor Author

the failures dont seem related to this change are they?

@aparnajyothi-y
Copy link
Contributor

Hello @marco-ippolito, Thank you for your pull request! We are currently reviewing it. To resolve the check failures, could you please rebase your branch with the main branch and push the changes.

@marco-ippolito
Copy link
Contributor Author

@aparnajyothi-y thanks, rebased

@aparnajyothi-y
Copy link
Contributor

Hello marco-ippolito,
The fallback log message could be clarified to reduce potential confusion between falling back directly from Node and falling back to downloading from the Node mirror URL. Currently, it states: "Falling back to download directly from Node" for both scenarios.
A slight adjustment could provide clearer context in the logs. Please feel free to reach out if you have any concerns.
Screenshot 2025-03-27 at 6 46 41 PM

@marco-ippolito
Copy link
Contributor Author

@aparnajyothi-y change the message to Not found in manifest. Falling back to download directly from 'your-mirror'

@marco-ippolito marco-ippolito force-pushed the mirror branch 2 times, most recently from 248ba43 to 40509ec Compare March 27, 2025 13:52
@marco-ippolito
Copy link
Contributor Author

I wonder if we can merge this

@aparnajyothi-y
Copy link
Contributor

Hello @marco-ippolito, With the latest commit, the log message now correctly displays the mirror URL when provided, which is the expected behavior. However, in the default fallback scenario (when no mirror URL is provided), the log message currently shows: "Falling back to download directly from." Instead, it should remain as it was previously, showing: "Falling back to download directly from Node."
This log message should remain unchanged for the default fallback behavior.
Please feel free to reach out if you need further clarification or have any concerns.
Screenshot 2025-03-28 at 9 18 07 PM

@marco-ippolito
Copy link
Contributor Author

@aparnajyothi-y thanks I have updated the code

@aparnajyothi-y
Copy link
Contributor

Hello @marco-ippolito, With the latest commit, the log message still showing: "Falling back to download directly from" Instead, it should remain as it was previously, showing: "Falling back to download directly from Node"
This log message should remain unchanged for the default fallback behavior.
Please feel free to reach out if you need further clarification or have any concerns.
image

@marco-ippolito
Copy link
Contributor Author

@aparnajyothi-y amended

@HarithaVattikuti HarithaVattikuti merged commit e3ce749 into actions:main Apr 2, 2025
200 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add input for NodeJS distribution url Support node.js mirror like nvm
5 participants