add dart analyzer #56
Conversation
* feature: improve starting from zero UX * ux: update API token instructions in welcome message * chore: update GitHub Actions workflow to initialize cli-v2 and remove Windows support * feature: installation progress bar * feature: enhance installation checks and user feedback * refactor: update configuration handling and directory creation
* pmd configuration
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
@heliocodacy there was a sync about the token on the analyze command. And the decision moving forward, is to have the token as input only for the init command.
So consider removing the configuration part from this PR, so we can focus on merge the installation and running. Or focus the configuration on being created during the init with the api-token
Co-authored-by: Joao Machado <13315199+machadoit@users.noreply.github.com>
| cmd.Stderr = os.Stderr | ||
| cmd.Stdout = os.Stdout | ||
| cmd.Run() |
There was a problem hiding this comment.
The command is executed twice in the SARIF branch: once to capture output and again after writing the SARIF file. This may lead to duplicated execution or unexpected behavior; consider refactoring to run the command only once and reuse the captured output.
| cmd.Stderr = os.Stderr | |
| cmd.Stdout = os.Stdout | |
| cmd.Run() | |
| // Reuse the captured output, no need to run the command again |
Copilot uses AI. Check for mistakes.
plugins/tool-utils.go
Outdated
| @@ -122,21 +122,32 @@ func ProcessTools(configs []ToolConfig, toolDir string) (map[string]*ToolInfo, e | |||
| if err != nil { | |||
| return nil, fmt.Errorf("error reading plugin.yaml for %s: %w", config.Name, err) | |||
| } | |||
|
|
|||
| fmt.Println("Plugin path", pluginPath) | |||
There was a problem hiding this comment.
[nitpick] This debug print appears to be left in production code. Consider removing or replacing it with proper logging if necessary.
| fmt.Println("Plugin path", pluginPath) | |
| log.Printf("Plugin path: %s", pluginPath) |
Copilot uses AI. Check for mistakes.
* feature: improve starting from zero UX * ux: update API token instructions in welcome message * chore: update GitHub Actions workflow to initialize cli-v2 and remove Windows support * feature: installation progress bar * feature: enhance installation checks and user feedback * refactor: update configuration handling and directory creation
hjrocha
force-pushed
the
feature/add-dartanalyzer
branch
from
2ce5d9e to
c97592d
Compare
|
|
||
| // Check if any config file exists | ||
| configExists := false | ||
| for _, configFile := range configFiles { |
There was a problem hiding this comment.
We discussed that you can rely on the ConfigFileExists that is tested and looks for files both on the .codacy/configs/ folder and root.
Not the biggest fan, but we aligned that that you can do it custom. However, I am failing to see where you ever read the generated config file at all 🤔
There was a problem hiding this comment.
this will stay to support the next iteration :)
heliocodacy
force-pushed
the
feature/add-dartanalyzer
branch
from
aed30f9 to
3c0e751
Compare
No description provided.