-
Notifications
You must be signed in to change notification settings - Fork 1
Restructure tools folder #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 29 out of 31 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tools/test/eslint/.eslintrc.json: Language not supported
- tools/test/eslint/config.json: Language not supported
Comments suppressed due to low confidence (3)
tools/test/eslint/test.js:1
- [nitpick] The variable name 'foo' is ambiguous and may reduce clarity in tests. Consider using a more descriptive name if the test logic becomes more complex.
var foo = "bar"
tools/pmd/pmdConfigCreator.go:11
- Ensure that the embedded file path 'default-ruleset.xml' is correct relative to this file after the package restructuring. An incorrect path may cause the default ruleset to fail to load.
//go:embed default-ruleset.xml
cmd/analyze.go:198
- This TODO comment indicates that the config file parameter is not yet handled. Either implement support for passing the config file or remove the comment and document why an empty parameter is acceptable.
//todo pass config file
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- tools/test/eslint/config.json: Language not supported
Comments suppressed due to low confidence (1)
cmd/analyze.go:198
- Address the TODO comment by either implementing the functionality to pass the configuration file for ESLint or referencing an issue for future work to avoid ambiguity in analysis behavior.
//todo pass config file
@@ -77,7 +85,7 @@ func TestCreatePmdConfig(t *testing.T) { | |||
generatedConfig := CreatePmdConfig(config) | |||
|
|||
// Read expected ruleset | |||
expectedRulesetPath := filepath.Join("testdata", "repositories", "pmd", "expected-ruleset.xml") | |||
expectedRulesetPath := "expected-ruleset.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the expected ruleset file path is correct relative to the test execution directory. If the file is located in a subdirectory, consider using a dynamic file path construction similar to filepath.Join.
expectedRulesetPath := "expected-ruleset.xml" | |
expectedRulesetPath := filepath.Join("tools", "test", "pmd", "expected-ruleset.xml") |
Copilot uses AI. Check for mistakes.
No description provided.