Skip to content

feat: add all branches option to TA branch selector #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

we want to allow users to not filter by any specific branch and aggregate the results from all branches

we also want to make this the default option when users land on the tests tab from now on

i'm putting this behind a feature flag because the backend is not capable of serving this data yet since it relies on the TA timescale data migration, and there's an equivalent API change that needs to be made for this to work correctly as well

fixed a thing where when users were searching through the branch selector for a specific branch we were still pinning the default branch to the top of the selection

also the all branches view has all the nice stuff that the default branch view has: metrics section, reset to default button, etc.

we want to allow users to not filter by any specific branch and
aggregate the results from all branches

we also want to make this the default option when users land on the
tests tab from now on

i'm putting this behind a feature flag because the backend is not
capable of serving this data yet since it relies on the TA timescale
data migration
@codecov-staging
Copy link

codecov-staging bot commented Apr 11, 2025

Bundle Report

Changes will increase total bundle size by 1.03kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.22MB 468 bytes (0.01%) ⬆️
gazebo-staging-esm 6.29MB 567 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 567 bytes 48.77kB 1.18%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/MetricsSection/MetricsSection.tsx → Total Size: 13.6kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/BranchSelector/BranchSelector.tsx → Total Size: 4.49kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/SelectorSection.tsx → Total Size: 5.96kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsTable/FailedTestsTable.tsx → Total Size: 11.62kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 468 bytes 45.1kB 1.05%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsTable/FailedTestsTable.tsx → Total Size: 11.62kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/BranchSelector/BranchSelector.tsx → Total Size: 4.49kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/SelectorSection.tsx → Total Size: 5.96kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/MetricsSection/MetricsSection.tsx → Total Size: 13.6kB

Copy link

codecov bot commented Apr 11, 2025

Bundle Report

Changes will increase total bundle size by 1.03kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.22MB 468 bytes (0.01%) ⬆️
gazebo-production-esm 6.29MB 567 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 468 bytes 45.1kB 1.05%

Files in assets/index-legacy.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/SelectorSection.tsx → Total Size: 5.96kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsTable/FailedTestsTable.tsx → Total Size: 11.62kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/BranchSelector/BranchSelector.tsx → Total Size: 4.49kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/MetricsSection/MetricsSection.tsx → Total Size: 13.6kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 567 bytes 48.77kB 1.18%

Files in assets/index.*.js:

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsTable/FailedTestsTable.tsx → Total Size: 11.62kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/BranchSelector/BranchSelector.tsx → Total Size: 4.49kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/MetricsSection/MetricsSection.tsx → Total Size: 13.6kB

  • ./src/pages/RepoPage/FailedTestsTab/FailedTestsPage/SelectorSection/SelectorSection.tsx → Total Size: 5.96kB

Copy link
Contributor

✅ Sentry found no issues in your recent changes ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SelectorSection/BranchSelector/BranchSelector.tsx 84.37% 4 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
- Coverage   98.72%   98.70%   -0.03%     
==========================================
  Files         827      827              
  Lines       15000    15024      +24     
  Branches     4289     4300      +11     
==========================================
+ Hits        14809    14829      +20     
- Misses        184      187       +3     
- Partials        7        8       +1     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 97.02% <100.00%> (+0.02%) ⬆️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.95% <100.00%> (+0.18%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.91% <100.00%> (+0.17%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 90.56% <84.37%> (-6.50%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.24% <87.17%> (-0.05%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea4ae6...b5fd5d5. Read the comment docs.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (cea4ae6) to head (b5fd5d5).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SelectorSection/BranchSelector/BranchSelector.tsx 84.37% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
- Coverage   98.72%   98.70%   -0.03%     
==========================================
  Files         827      827              
  Lines       15000    15024      +24     
  Branches     4281     4308      +27     
==========================================
+ Hits        14809    14829      +20     
- Misses        184      187       +3     
- Partials        7        8       +1     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 97.02% <100.00%> (+0.02%) ⬆️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.95% <100.00%> (+0.18%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.91% <100.00%> (+0.17%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 90.56% <84.37%> (-6.50%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.24% <87.17%> (-0.05%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea4ae6...b5fd5d5. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (cea4ae6) to head (b5fd5d5).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SelectorSection/BranchSelector/BranchSelector.tsx 84.37% 4 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
- Coverage   98.72%   98.70%   -0.03%     
==========================================
  Files         827      827              
  Lines       15000    15024      +24     
  Branches     4281     4300      +19     
==========================================
+ Hits        14809    14829      +20     
- Misses        184      187       +3     
- Partials        7        8       +1     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 97.02% <100.00%> (+0.02%) ⬆️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.95% <100.00%> (+0.18%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.91% <100.00%> (+0.17%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 90.56% <84.37%> (-6.50%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.24% <87.17%> (-0.05%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea4ae6...b5fd5d5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov-public-qa bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (cea4ae6) to head (b5fd5d5).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../SelectorSection/BranchSelector/BranchSelector.tsx 84.37% 4 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
- Coverage   98.72%   98.70%   -0.03%     
==========================================
  Files         827      827              
  Lines       15000    15024      +24     
  Branches     4289     4300      +11     
==========================================
+ Hits        14809    14829      +20     
- Misses        184      187       +3     
- Partials        7        8       +1     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 97.02% <100.00%> (+0.02%) ⬆️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.95% <100.00%> (+0.18%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 95.91% <100.00%> (+0.17%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 90.56% <84.37%> (-6.50%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.24% <87.17%> (-0.05%) ⬇️
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea4ae6...b5fd5d5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Apr 11, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
9531248 Fri, 11 Apr 2025 22:32:43 GMT Expired Expired
b5fd5d5 Mon, 14 Apr 2025 15:37:48 GMT Cloud Enterprise

@joseph-sentry joseph-sentry marked this pull request as ready for review April 14, 2025 13:43
@joseph-sentry joseph-sentry requested review from a team and removed request for a team April 14, 2025 13:43
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing to clean up, but looks all good 👍

selection = {
name: 'Select branch',
head: null,
console.log('selection', selection)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 🚓 🚨

Comment on lines 313 to 314
To see data for the {testData?.defaultBranch} branch, merge your PR
into the {testData?.defaultBranch} branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be some fallback copy if the default branch doesn't exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants