-
Notifications
You must be signed in to change notification settings - Fork 29
feat: add all branches option to TA branch selector #3842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
we want to allow users to not filter by any specific branch and aggregate the results from all branches we also want to make this the default option when users land on the tests tab from now on i'm putting this behind a feature flag because the backend is not capable of serving this data yet since it relies on the TA timescale data migration
Bundle ReportChanges will increase total bundle size by 1.03kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 1.03kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3842 +/- ##
==========================================
- Coverage 98.72% 98.70% -0.03%
==========================================
Files 827 827
Lines 15000 15024 +24
Branches 4289 4300 +11
==========================================
+ Hits 14809 14829 +20
- Misses 184 187 +3
- Partials 7 8 +1
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3842 +/- ##
==========================================
- Coverage 98.72% 98.70% -0.03%
==========================================
Files 827 827
Lines 15000 15024 +24
Branches 4281 4308 +27
==========================================
+ Hits 14809 14829 +20
- Misses 184 187 +3
- Partials 7 8 +1
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3842 +/- ##
==========================================
- Coverage 98.72% 98.70% -0.03%
==========================================
Files 827 827
Lines 15000 15024 +24
Branches 4281 4300 +19
==========================================
+ Hits 14809 14829 +20
- Misses 184 187 +3
- Partials 7 8 +1
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3842 +/- ##
==========================================
- Coverage 98.72% 98.70% -0.03%
==========================================
Files 827 827
Lines 15000 15024 +24
Branches 4289 4300 +11
==========================================
+ Hits 14809 14829 +20
- Misses 184 187 +3
- Partials 7 8 +1
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing to clean up, but looks all good 👍
selection = { | ||
name: 'Select branch', | ||
head: null, | ||
console.log('selection', selection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 🚓 🚨
To see data for the {testData?.defaultBranch} branch, merge your PR | ||
into the {testData?.defaultBranch} branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be some fallback copy if the default branch doesn't exist?
we want to allow users to not filter by any specific branch and aggregate the results from all branches
we also want to make this the default option when users land on the tests tab from now on
i'm putting this behind a feature flag because the backend is not capable of serving this data yet since it relies on the TA timescale data migration, and there's an equivalent API change that needs to be made for this to work correctly as well
fixed a thing where when users were searching through the branch selector for a specific branch we were still pinning the default branch to the top of the selection
also the all branches view has all the nice stuff that the default branch view has: metrics section, reset to default button, etc.