update minimum go version to go1.23 #5868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
status/2-code-review
area/go-sdk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5868 +/- ##
=======================================
Coverage 58.89% 58.89%
=======================================
Files 358 358
Lines 29961 29961
=======================================
Hits 17647 17647
Misses 11333 11333
Partials 981 981 🚀 New features to boost your workflow:
|
1 task
Benehiko
approved these changes
Feb 25, 2025
|
Let's discuss if we want to include this in 28.0.1, or keep this for a 28.1 release; this bump was needed if we needed #5869, but the CVE in that bump is really a false positive, so we don't need it for the CLI (other than for silencing scanners). Let me put this in draft, but we can decide what we want to do (mostly trying to keep the diff for the |
thaJeztah
force-pushed
the
bump_go_version
branch
2 times, most recently
from
4f6cb3a to
5337b0f
Compare
thaJeztah
force-pushed
the
bump_go_version
branch
from
5337b0f to
d847be9
Compare
thaJeztah
force-pushed
the
bump_go_version
branch
from
d847be9 to
57df303
Compare
Benehiko
approved these changes
Apr 16, 2025
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies; > all: upgrade go directive to at least 1.23.0 [generated] > > By now Go 1.24.0 has been released, and Go 1.22 is no longer supported > per the Go Release Policy (https://go.dev/doc/devel/release#policy). > > For golang/go#69095. This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_go_version
branch
from
57df303 to
1d768f8
Compare
vvoland
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies;
This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)