-
Notifications
You must be signed in to change notification settings - Fork 61.6k
RUNNER_NAME
and /repos/{owner}/{repo}/actions/runs/{run_id}/jobs
are incorrectly documented
#37046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For my reference, I added code to handle this change: which results in things working again: Note that nothing mentions that some of these things mangle spaces into |
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
@jsoref Thanks so much for opening a PR! I'll see if one of our SMEs can take a look. |
@jsoref apologies for the disruption. We have rolled out a fix now for the issue. |
@jsoref also, thank you for reporting this issue. |
@ericsciple: I don't suppose you can point to what the change looks like? My current items aren't working: Whereas they worked ~3 days ago: |
@jsoref, Here is a sample from my personal repo:
Excerpt from list-jobs-for-a-workflow-run response: "runner_id": 1000000114,
"runner_name": "GitHub Actions 1000000114", |
Thanks, a slight change from check-spelling/check-spelling@75e8f6b to check-spelling/check-spelling@8360222 seems to have resulted in things working again. |
@jsoref, out of curiosity, now that the fix has rolled out and
I am about to step away but I can test this later as well. |
@ericsciple yes, it works: https://github.com/check-spelling-sandbox/check-spelling/actions/runs/14673909814/attempts/1#summary-41186421291. Is this a promise not to make this breaking change again? Most people won't be running |
@jsoref, awesome! Thanks for confirming. Yes, this breaking change was unintentional. I will add an end-to-end test, so we don't accidentally regress this behavior again in the future. Again, apologies for the disruption and thank you for helping us identify this unintentional breaking change. |
I will let you know you shortly after the end-to-end test is in place (probably today or tomorrow). |
@jsoref an end-to-end test has been added now |
Thanks @ericsciple. I guess we can close this as resolved completed as the documentation now matches the implementation and there's an end-to-end test to enforce that. |
Thanks, @jsoref! I'm glad the issue got resolved. 👍 |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
What part(s) of the article would you like to see updated?
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
RUNNER_NAME
Hosted Agent
https://docs.github.com/en/rest/actions/workflow-jobs?apiVersion=2022-11-28#list-jobs-for-a-workflow-run
example response
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#runner-context
runner.name
Additional information
Between https://github.com/check-spelling-sandbox/check-spelling/actions/runs/13813316120 and https://github.com/check-spelling-sandbox/check-spelling/actions/runs/13835035831 the behavior of
RUNNER_NAME
and the github runner api changed.In the first run,
RUNNER_NAME
andrunner_name
had matching behavior. In the second run,RUNNER_NAME
is equivalent torunner_name
(with spaces changed to_
...) +"_"
+runner_id
.Note that there is no id property in the
runner
context and that the runner context name now appears to include a runner id (at least for github hosted runners).The text was updated successfully, but these errors were encountered: