Skip to content

Replace single line break with double line break for commit description in git blame hover popup #245779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025

Conversation

huntertran
Copy link
Contributor

Fix issue #245773

By design, markdown ignores single line break \n.
This behavior makes the git blame popup on mouse hover display a single line description for all the texts that has single line break. These line breaks display correctly on Github.com and on most of the git clients.

This fix replaces all the variances of line break (\r, \n, \r\n and \n\n) with double line break \n\n, so the markdown correctly displays line break in the popup

@huntertran huntertran requested a review from lszomoru April 9, 2025 01:24
@lszomoru lszomoru added the git GIT issues label Apr 22, 2025
@lszomoru lszomoru added this to the April 2025 milestone Apr 22, 2025
Copy link
Member

@lszomoru lszomoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.

@lszomoru lszomoru enabled auto-merge (squash) April 22, 2025 19:16
@huntertran
Copy link
Contributor Author

@microsoft-github-policy-service agree

@lszomoru lszomoru merged commit 30d16b2 into microsoft:main Apr 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants