-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Scope down shell env api #245899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope down shell env api #245899
Conversation
if (shellLaunchConfig.shellIntegrationEnvironmentReporting) { | ||
// TODO: (Perf) Temporarily pass lists of hardcoded env vars for shell env api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this describing the change here? Should TODO
be removed and should the comment be moved to be above scopedDownShellEnvs
?
Also nit, but list
vs lists
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally! valid 100%
I took the feedback here => 0a6d37b
I see that become defined when I hit enter and @anthonykim1 has told me it's expected that it could initially be |
Resolves: #245695, #244140