-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Fix mode picker in quick chat #246052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mode picker in quick chat #246052
Conversation
Oh I just noticed that the changed file list is going out into space on the right in my original screenshot. Not sure what to do, I can do this: ![]() But that also looks a bit off. Or I can leave it, or we can disable the mode picker in quick chat, or any other ideas @TylerLeonhardt ? |
I'm guessing the action bar on the right is filling the height... is it this guy?: vscode/src/vs/workbench/contrib/chat/browser/chatInputPart.ts Lines 963 to 972 in 3f1d520
It should be only used for quick chat, right? So maybe we have the buttons go to to the top of the column? |
Sure, you don't think it would look oddly off-center though? |
It does look weird... I just also realize that as more files are added the input will be pushed down. Not great. Really the widget should be flipped so the files changed are underneath so it grows down... just like we did with the other stuff like attachments... then I think it wouldn't look so weird off-center... or we even capture the action bar and make it a part of the container and stretch the thing to full width. Another idea, which is probably bad, we give quick chat at titlebar with the buttons in that. But... idk... if you think that's a lot of work, we can just disable the mode switcher for now. But I do feel like we may head towards "Agent" being more focused in which case that work may be necessary sooner rather than later. |
I would like to have agent stuff in quick chat, but also, editing in quick chat feels a bit weird, because I inherently can't really look at the edits with quick chat on top. Maybe when we have some form of custom modes, quick chat could be a mode without editing? I think I'd find that more useful. I think it would also be weird to have an unresolved edit session, then when I close quick chat, should it force me to keep/undo the changes? Or else it stays unresolved forever with no UI to see the edit session state? Also a bit weird. |
Yeah lots of details to work through, better just hide the mode picker for now I guess? |
It works, but is it weird? cc @TylerLeonhardt