Skip to content

Render chat changes in editor if diff is available #246440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne self-assigned this Apr 14, 2025
@DonJayamanne DonJayamanne requested review from jrieken and removed request for jrieken April 14, 2025 02:20
@DonJayamanne DonJayamanne marked this pull request as ready for review April 14, 2025 02:43
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 14, 2025
@DonJayamanne DonJayamanne enabled auto-merge (squash) April 14, 2025 07:01
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might require a different approach (see comment above) - I wonder when notebook editing sends the "final edit"-signal? That should make the isCurrentBeingModifiedBy (and diff-info) change and kick off all the renderings

@DonJayamanne DonJayamanne requested a review from jrieken April 22, 2025 04:50
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DonJayamanne DonJayamanne merged commit dffb866 into main Apr 22, 2025
8 checks passed
@DonJayamanne DonJayamanne deleted the don/new-guineafowl branch April 22, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants