[ubuntu] Unpin the minikube version #12480
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kishorekumar-anchala
force-pushed
the
fix-kube-err
branch
from
35f59fd to
fa9c2ed
Compare
kishorekumar-anchala
added
CI ubuntu-2204
CI ubuntu-2404
and removed
CI ubuntu-all
labels
kishorekumar-anchala
added
CI ubuntu-all
and removed
CI ubuntu-2204
CI ubuntu-2404
labels
kishorekumar-anchala
added
CI ubuntu-2204
CI ubuntu-2404
and removed
CI ubuntu-all
CI ubuntu-2204
CI ubuntu-2404
labels
kishorekumar-anchala
added
CI ubuntu-all
and removed
CI ubuntu-all
CI ubuntu-2204
CI ubuntu-2404
labels
kishorekumar-anchala
added
CI ubuntu-2204
CI ubuntu-2404
and removed
CI ubuntu-all
labels
kishorekumar-anchala
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Ubuntu image build script to unpin the Minikube version and always fetch the latest release, adjusting download, checksum validation, and installation steps accordingly.
- Switches from a fixed Minikube version (v1.34.0) to
"latest" - Uses
download_with_retryto fetch the binary and then performs checksum validation - Installs the downloaded Minikube binary to
/usr/local/bin/minikube
Comments suppressed due to low confidence (2)
images/ubuntu/scripts/build/install-kubernetes-tools.sh:36
- Ensure that
download_with_retryactually returns the path to the downloaded file. If it writes to a fixed filename instead, you’ll need to reference that name when computing the checksum and during installation.
minikube_binary_path=$(download_with_retry "https://storage.googleapis.com/minikube/releases/${minikube_version}/minikube-linux-amd64")
images/ubuntu/scripts/build/install-kubernetes-tools.sh:39
- Using the literal tag
"latest"may not resolve correctly in the GitHub Releases API. You may need to first query/releases/latestto get the actual tag name or handle redirection to ensure the checksum matches the right asset.
minikube_hash=$(get_checksum_from_github_release "kubernetes/minikube" "linux-amd64" "${minikube_version}" "SHA256")
| minikube_hash=$(get_checksum_from_github_release "kubernetes/minikube" "linux-amd64" "1.34.0" "SHA256") | ||
| use_checksum_comparison "minikube-linux-amd64" "${minikube_hash}" | ||
| # Download and install minikube | ||
| minikube_version="latest" |
There was a problem hiding this comment.
[nitpick] Hard-coding latest can lead to non-reproducible builds. Consider parameterizing the version via an environment variable or defaulting to a specific tag while still allowing overrides.
Suggested change
| minikube_version="latest" | |
| minikube_version="${MINIKUBE_VERSION:-1.30.0}" |
Copilot uses AI. Check for mistakes.
|
|
||
| # Install minikube | ||
| install minikube-linux-amd64 /usr/local/bin/minikube | ||
| # Supply chain security - Minikube |
There was a problem hiding this comment.
[nitpick] Comment casing is inconsistent with earlier lines (minikube vs Minikube). Standardize on one spelling/casing for clarity and consistency.
Suggested change
| # Supply chain security - Minikube | |
| # Supply chain security - minikube |
Copilot uses AI. Check for mistakes.
vidyasagarnimmagaddi
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will upgrade the minikube version to the latest.
Related issue:
Check list