Skip to content

Include python version in PyPy python-version output #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdce8p
Copy link

@cdce8p cdce8p commented May 17, 2025

Description:
The PyPy version is shared between different python versions. To uniquely identify a specific release, the output should contain both resolvedPythonVersion and resolvedPyPyVersion.

Related issue:
Fixes #1109

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@aparnajyothi-y aparnajyothi-y requested a review from Copilot July 11, 2025 05:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the PyPy version output by including both the underlying Python version and the PyPy release version in the python-version output.

  • Update the python-version output to pypy{resolvedPythonVersion}-{resolvedPyPyVersion} instead of just the PyPy version.
  • Remove the old single-version output line.
  • Return both resolvedPythonVersion and resolvedPyPyVersion from the function.
Comments suppressed due to low confidence (2)

src/find-pypy.ts:101

  • Add or update unit tests to verify that the python-version output now correctly combines resolvedPythonVersion and resolvedPyPyVersion. This ensures the new format is validated across different PyPy releases.
    `pypy${resolvedPythonVersion}-${resolvedPyPyVersion}`

src/find-pypy.ts:100

  • Update any related documentation (such as README or action metadata) to reflect that the python-version output now includes both the Python and PyPy version, formatted as pypy{pythonVersion}-{pypyVersion}.
    'python-version',

@aparnajyothi-y
Copy link
Contributor

closing and reopening this PR to trigger CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python-version output for PyPy isn't unique across different versions
3 participants