Skip to content

linux-image: provide wireguard-modules #7812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

amazingfate
Copy link
Contributor

Description

I'm trying to generate a debian iso with armbian's kernel, but live-build keep installing linux-image-rt-arm64. I find it as rec dependency of wireguard-tools. And both linux-image-rt-arm64 from debian and linux-image-generic from ubuntu are providing it.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • ./compile.sh kernel BOARD=rock-5b BRANCH=vendor DEB_COMPRESS=xz

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@amazingfate amazingfate requested a review from a team as a code owner February 9, 2025 17:35
@github-actions github-actions bot added Needs review Seeking for review Framework Framework components size/small PR with less then 50 lines labels Feb 9, 2025
@igorpecovnik
Copy link
Member

Provides wireguard-modules solves this problem?

@amazingfate
Copy link
Contributor Author

Provides wireguard-modules solves this problem?

live-build need a apt repo to build. I haven't checked it. I'm finding other way to get rid of the issue so don't be pushed to merge this quickly.

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress 02 Milestone: First quarter release 05 Milestone: Second quarter release labels Feb 10, 2025
@leggewie
Copy link
Collaborator

this should eventually be fixed in APA

@igorpecovnik
Copy link
Member

this should eventually be fixed in

You mean by introducing virtual kernel package? Otherwise, man packaging should stay "as as" inside build framework. Splitting this is calling for troubles.

@leggewie
Copy link
Collaborator

I think that APA is the proper place to document and publish this kind of packaging-related information. There's too much unmaintainable/hard-to-maintain shell code in armbian/build, I would say.

@leggewie
Copy link
Collaborator

@igorpecovnik I did not mean to stall this PR, just to mention about the future path we intend to take to raise awareness.

Is there a reason NOT to merge this? I am not sure if the package in question does indeed provide wireguard-modules. If it does not, this should NOT go in. But if it does, it should by all means.

@igorpecovnik
Copy link
Member

I think this can be merged as we provide wg modules by default and this is (probably) virtual package that makes modules via DKMS. None of this is needed in Armbian.

Copy link
Collaborator

@leggewie leggewie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, assuming the armbian-kernel does indeed provide those modules

@leggewie leggewie merged commit 94a72b9 into armbian:main Aug 11, 2025
1 check passed
@EvilOlaf
Copy link
Member

All Armbian kernels should have Wireguard as module by default. This hopefully solves the issue having non-working upstream kernels installed as recommendation when trying to install wireguard-tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release 05 Milestone: Second quarter release Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

4 participants