-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
linux-image: provide wireguard-modules #7812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux-image: provide wireguard-modules #7812
Conversation
Provides |
live-build need a apt repo to build. I haven't checked it. I'm finding other way to get rid of the issue so don't be pushed to merge this quickly. |
this should eventually be fixed in APA |
You mean by introducing virtual kernel package? Otherwise, man packaging should stay "as as" inside build framework. Splitting this is calling for troubles. |
I think that APA is the proper place to document and publish this kind of packaging-related information. There's too much unmaintainable/hard-to-maintain shell code in armbian/build, I would say. |
@igorpecovnik I did not mean to stall this PR, just to mention about the future path we intend to take to raise awareness. Is there a reason NOT to merge this? I am not sure if the package in question does indeed provide wireguard-modules. If it does not, this should NOT go in. But if it does, it should by all means. |
I think this can be merged as we provide wg modules by default and this is (probably) virtual package that makes modules via DKMS. None of this is needed in Armbian. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, assuming the armbian-kernel does indeed provide those modules
All Armbian kernels should have Wireguard as module by default. This hopefully solves the issue having non-working upstream kernels installed as recommendation when trying to install wireguard-tools. |
Description
I'm trying to generate a debian iso with armbian's kernel, but live-build keep installing linux-image-rt-arm64. I find it as rec dependency of wireguard-tools. And both linux-image-rt-arm64 from debian and linux-image-generic from ubuntu are providing it.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
./compile.sh kernel BOARD=rock-5b BRANCH=vendor DEB_COMPRESS=xz
Checklist:
Please delete options that are not relevant.