Fix Resource Leak in ArtResizer with test cases #5746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Resource Leak in ArtResizer : Fixes #5689
Hello,
This is my first time submitting a pull request so any feedback would be much appreciated.
I was attempting to make sure that art resizer does not keep file handles open. In artresizer.py I manual remove opened files to ensure there no leftover nor corrupt file in path_out.
I created a test called test_artresizer_resources.py. For testing, I used the pillow library which was added to pyproject.toml. The test suite works by counting the number of files before and after the operation while ensuring the proper file is returned. This test file was failing before I added my changes but was resolved when the changes were made. I ran my code against the entire pytest suite which seemed to work as intended.