Rewrite and speed up query tests

[snejus]

Previously:

Poe => pytest -p no:cov test/test_query.py --durations=10
=============================================================================== test session starts ===============================================================================
platform linux -- Python 3.9.20, pytest-8.3.5, pluggy-1.5.0
cachedir: /tmp/pytest_cache
rootdir: /home/sarunas/repo/beets
configfile: setup.cfg
plugins: anyio-4.9.0, xdist-3.6.1, requests-mock-1.12.1, flask-1.3.0
collected 133 items                                                                                                                                                               

test/test_query.py .....................................................................................................................................                 [133/133]

============================================================================== slowest 10 durations ===============================================================================
0.13s call     test/test_query.py::NotQueryTest::test_type_none
0.12s call     test/test_query.py::NotQueryTest::test_fast_vs_slow
0.11s call     test/test_query.py::GetTest::test_singleton_0
0.11s call     test/test_query.py::NotQueryTest::test_type_substring
0.11s call     test/test_query.py::RelatedQueriesTest::test_filter_items_by_common_field
0.11s call     test/test_query.py::RelatedQueriesTest::test_get_items_filter_by_album_field
0.11s call     test/test_query.py::NotQueryTest::test_type_boolean
0.11s call     test/test_query.py::NotQueryTest::test_type_or
0.11s call     test/test_query.py::NotQueryTest::test_type_numeric
0.11s call     test/test_query.py::NotQueryTest::test_type_true
=============================================================================== 133 passed in 9.94s ===============================================================================

Now:

Poe => pytest -p no:cov test/test_query.py --durations=10
=============================================================================== test session starts ================================================================================
platform linux -- Python 3.9.20, pytest-8.3.5, pluggy-1.5.0
cachedir: /tmp/pytest_cache
rootdir: /home/sarunas/repo/beets
configfile: setup.cfg
plugins: anyio-4.9.0, xdist-3.6.1, requests-mock-1.12.1, flask-1.3.0
collected 129 items                                                                                                                                                                

test/test_query.py .................................................................................................................................                      [129/129]

=============================================================================== slowest 10 durations ===============================================================================
0.10s setup    test/test_query.py::TestRelatedQueries::test_related_query[match-album-with-item-field-query]
0.09s setup    test/test_query.py::TestGet::test_get_query[''-['first', 'second', 'third']]
0.09s setup    test/test_query.py::TestPathQuery::test_explicit[exact-match]
0.09s setup    test/test_query.py::TestQuery::test_value_type[parse-true]
0.08s setup    test/test_query.py::TestDefaultSearchFields::test_search[album-match-album]
0.02s call     test/test_query.py::TestGet::test_query_logic[SubstringQuery('album', 'ba', fast=True)-{'third'}]
0.02s call     test/test_query.py::TestGet::test_query_logic[NoneQuery('rg_track_gain', True)-set()]
0.02s call     test/test_query.py::TestGet::test_query_logic[NumericQuery('year', '2001..2002', fast=True)-{'third'}]
0.02s call     test/test_query.py::TestGet::test_query_logic[RegexpQuery('artist', re.compile('^t'), fast=True)-{'first'}]
0.02s call     test/test_query.py::TestGet::test_query_logic[OrQuery([BooleanQuery('comp', 1, fast=True), NumericQuery('year', '2002', fast=True)])-{'third'}]
=============================================================================== 129 passed in 2.53s ================================================================================

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[Copilot]

Pull Request Overview

This PR refactors test utilities and updates query abstractions to improve test performance and clarity.

• Adds a pytest hook to generate readable IDs for parametrized tests.
• Refactors the item fixture to accept keyword overrides via defaults.
• Marks Query methods as abstract and adjusts their default implementations.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
test/conftest.py	Import inspect and Query, add pytest_make_parametrize_id hook for clearer test IDs.
beets/test/_common.py	Extend item() fixture to accept **kwargs and merge with defaults.
beets/dbcore/query.py	Annotate clause and match as abstract, remove default returns, and change col_clause to raise.

Comments suppressed due to low confidence (3)

beets/dbcore/query.py:99

• The default implementation of clause no longer returns (None, ()), so it implicitly returns None. Restore return None, () or explicitly raise NotImplementedError if there is no default behavior.

    def clause(self) -> tuple[str | None, Sequence[Any]]:

beets/dbcore/query.py:105

• The abstract match method has no implementation or exception, so it will implicitly return None. Add a raise NotImplementedError or a proper fallback implementation.

    def match(self, obj: Model):

beets/dbcore/query.py:154

• Changing col_clause to always raise NotImplementedError removes the previous default (self.field, ()) behavior. If subclasses rely on that fallback, this will break them—either restore the default return or ensure all subclasses implement it.

    def col_clause(self) -> tuple[str, Sequence[SQLiteType]]:

[semohr]

Looks like some good stuff to me 👍

I appreciate the use of the parameterize fixture, the tests are way more understandable now!

You checked that we still have the same coverage?