-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix 'from_scratch': delete all tags before writing new tags to file #5828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
## Github Issues Fixes beetbox#3706 Related beetbox#5165 ## Issue Comment tags are written to file even if option 'from_scratch' is used. The same tags are not written to the file if imported together with other files as album. Therefore 'from_scratch' is not working as described in the documentation. ## Solution 1. Add test: Adapt the function from the 'regular' import class and insert it in the class for the singleton import test. 2. Fix bug : Add check for 'from_scratch' option. If used, clear metadata before applying 'new' metadata with autotag. 3. No documentation change needed. Option now works as described in the documentation. 4. Add changelog.
Not sure what's up with CI here. The change itself (didn't look at the test now) looks good to me: This was never implemented for |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay; I've just had another look at the PR in its entirety. Looks good to me!
There's one small mishap regarding the changelog, see the inline comment. Could you fix that? Then, this can be merged :)
Just resolved the merge conflict there. poe lint-docs reported "No Problems found." locally on my machine. |
Description
Fixes #3706.
Issue
Comment tags are written to file even if option 'from_scratch' is used. The same tags are not written to the file if imported together with other files as album. Therefore 'from_scratch' is not working as described in the documentation.
Solution
To Do
Documentation.