-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix pipx install action #5841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipx install action #5841
Conversation
I have reported the issue with BrandonLWhite/pipx-install-action@v1.0.3 failing on Windows here: BrandonLWhite/pipx-install-action#62
Looks good to me as a quick fix to CI 👍 Copilot's suggestions around consistency probably make sense? However, I am wondering about the reliability of the new action compared to the previous one: The code looks fine superficially. It's also a one-man-show, where the author seems to have limited time to maintain it, and I'm not sure it's in widespread use. Maybe this would in fact be a reason to push for |
This reverts commit ab9b2e0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to resolve Windows compatibility issues in the pipx install action used in CI workflows. The changes update the pipx-install-action version in multiple workflow files, although the diff does not reflect the alternative action noted in the PR description.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
.github/workflows/make_release.yaml | Updated pipx-install-action version from v1.0.1 to v1.0.3 |
.github/workflows/lint.yml | Updated pipx-install-action version from v1.0.1 to v1.0.3 |
.github/workflows/integration_test.yaml | Updated pipx-install-action version from v1.0.1 to v1.0.3 |
.github/workflows/ci.yaml | Updated pipx-install-action version from v1.0.1 to v1.0.3 |
I started looking into Thus I reverted the commit which introduced another action on Windows. The only change that this PR makes is pipx-install-action version upgrade. |
Fix pipx-install-action Windows compatibility issue
Replace
BrandonLWhite/pipx-install-action@v1.0.3
withthreeal/pipx-install-action@v1.0.0
in CI workflow due to Windows compatibility issues.Changes:
Edit: received a reply from
pipx-install-action
maintainer with a fix: simply remove the breaking cache from GitHub Actions: this worked fine.Thus I reverted the commit which introduced another action on Windows. The only change that this PR makes is
pipx-install-action
version upgrade.