Skip to content

Fix pipx install action #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2025
Merged

Fix pipx install action #5841

merged 3 commits into from
Jun 29, 2025

Conversation

snejus
Copy link
Member

@snejus snejus commented Jun 24, 2025

Fix pipx-install-action Windows compatibility issue

Replace BrandonLWhite/pipx-install-action@v1.0.3 with threeal/pipx-install-action@v1.0.0 in CI workflow due to Windows compatibility issues.

Changes:

Edit: received a reply from pipx-install-action maintainer with a fix: simply remove the breaking cache from GitHub Actions: this worked fine.

Thus I reverted the commit which introduced another action on Windows. The only change that this PR makes is pipx-install-action version upgrade.

snejus added 2 commits June 24, 2025 12:08
I have reported the issue with BrandonLWhite/pipx-install-action@v1.0.3
failing on Windows here:
BrandonLWhite/pipx-install-action#62
@snejus snejus requested review from Copilot, semohr and wisp3rwind June 24, 2025 11:10
Copilot

This comment was marked as outdated.

@wisp3rwind
Copy link
Member

Looks good to me as a quick fix to CI 👍 Copilot's suggestions around consistency probably make sense?

However, I am wondering about the reliability of the new action compared to the previous one: The code looks fine superficially. It's also a one-man-show, where the author seems to have limited time to maintain it, and I'm not sure it's in widespread use.

Maybe this would in fact be a reason to push for uv: It does come with a reusable action by the authors (see https://docs.astral.sh/uv/guides/integration/github/) which supports caching, and it can manage python and tools. (I think we could also use uv only in this role for now, and continue building with poetry.)

@snejus snejus requested a review from Copilot June 29, 2025 12:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to resolve Windows compatibility issues in the pipx install action used in CI workflows. The changes update the pipx-install-action version in multiple workflow files, although the diff does not reflect the alternative action noted in the PR description.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/make_release.yaml Updated pipx-install-action version from v1.0.1 to v1.0.3
.github/workflows/lint.yml Updated pipx-install-action version from v1.0.1 to v1.0.3
.github/workflows/integration_test.yaml Updated pipx-install-action version from v1.0.1 to v1.0.3
.github/workflows/ci.yaml Updated pipx-install-action version from v1.0.1 to v1.0.3

@snejus
Copy link
Member Author

snejus commented Jun 29, 2025

Looks good to me as a quick fix to CI 👍 Copilot's suggestions around consistency probably make sense?

However, I am wondering about the reliability of the new action compared to the previous one: The code looks fine superficially. It's also a one-man-show, where the author seems to have limited time to maintain it, and I'm not sure it's in widespread use.

Maybe this would in fact be a reason to push for uv: It does come with a reusable action by the authors (see https://docs.astral.sh/uv/guides/integration/github/) which supports caching, and it can manage python and tools. (I think we could also use uv only in this role for now, and continue building with poetry.)

I started looking into uv and meanwhile received a comment under the issue with a fix, so received a reply from pipx-install-action maintainer with a fix: simply remove the breaking cache from GitHub Actions which worked fine.

Thus I reverted the commit which introduced another action on Windows. The only change that this PR makes is pipx-install-action version upgrade.

@snejus snejus merged commit a005941 into master Jun 29, 2025
22 of 29 checks passed
@snejus snejus deleted the fix-pipx-install-action branch June 29, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants