Skip to content

fix(infotext): preserve spaces around inline tag values #4283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

michaelmkraus
Copy link
Contributor

Proposed changes

  • fix(infotext): preserve spaces around inline tag values
    Flex containers strip trailing/leading whitespace around inline elements. Add white-space: pre so that spaces are rendered correctly.

closes #2714

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Copy link
Contributor

@michaelmkraus michaelmkraus moved this to 🕋 In progress in UX Engineering Team Backlog May 27, 2025
@michaelmkraus michaelmkraus moved this from 🕋 In progress to 👀 In review in UX Engineering Team Backlog May 27, 2025
@mfranzke mfranzke requested a review from Copilot June 16, 2025 05:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with inline tag spacing in the infotext component by adding a CSS rule that preserves whitespace in flex containers. In addition, multiple snapshot files for textarea, radio, and checkbox components across various browsers have been removed.

  • Fixed CSS to render spaces correctly in inline elements
  • Removed outdated snapshot files to reflect updated UI behavior

Reviewed Changes

Copilot reviewed 187 out of 187 changed files in this pull request and generated no comments.

File Description
packages/components/src/components/infotext/infotext.scss Added white-space: pre to preserve spaces around inline tag values
All snapshots files Removed snapshot files across multiple platforms and components
Comments suppressed due to low confidence (2)

packages/components/src/components/infotext/infotext.scss:13

  • [nitpick] Consider adding a comment explaining why 'white-space: pre' is required here to preserve spaces, as its behavior in flex containers may not be immediately obvious to future maintainers.
white-space: pre;

Multiple snapshot files:1

  • Confirm that the deletion of these snapshot files is intentional and that updated snapshot tests (or alternative testing strategies) are in place to verify the UI changes.
Entire file removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

DBInfotext is missing spaces around tags like bold, code etc
3 participants