-
Notifications
You must be signed in to change notification settings - Fork 10
fix(infotext): preserve spaces around inline tag values #4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-preserve-whitespaces-infotext |
This reverts commit 7bf0dc4.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with inline tag spacing in the infotext component by adding a CSS rule that preserves whitespace in flex containers. In addition, multiple snapshot files for textarea, radio, and checkbox components across various browsers have been removed.
- Fixed CSS to render spaces correctly in inline elements
- Removed outdated snapshot files to reflect updated UI behavior
Reviewed Changes
Copilot reviewed 187 out of 187 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/components/src/components/infotext/infotext.scss | Added white-space: pre to preserve spaces around inline tag values |
All snapshots files | Removed snapshot files across multiple platforms and components |
Comments suppressed due to low confidence (2)
packages/components/src/components/infotext/infotext.scss:13
- [nitpick] Consider adding a comment explaining why 'white-space: pre' is required here to preserve spaces, as its behavior in flex containers may not be immediately obvious to future maintainers.
white-space: pre;
Multiple snapshot files:1
- Confirm that the deletion of these snapshot files is intentional and that updated snapshot tests (or alternative testing strategies) are in place to verify the UI changes.
Entire file removal
Proposed changes
Flex containers strip trailing/leading whitespace around inline elements. Add
white-space: pre
so that spaces are rendered correctly.closes #2714
Types of changes