Skip to content

chore: converted declarations to dataset JS API #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: converted declarations to dataset JS API #4349

wants to merge 5 commits into from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Jun 10, 2025 •
edited
Loading

Proposed changes

Specifically for data- it would be nice to use the .dataset JavaScript API in general.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke requested a review from nmerget as a code owner June 10, 2025 13:42
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jun 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-moved-to-dataset-js-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🍄🆙improvement New feature or request
Projects
UX Engineering Team Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke