Skip to content

test(playwright): deactivating animations #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

test(playwright): deactivating animations #4353

wants to merge 8 commits into from

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

When running visual regression tests to retrieve static screenshots, we shouldn't wait for animations to finish, but deactivate animations on our browser setting. As a sideeffect on retrieving flacky tests we might as well get notified of tests in which we haven't implemented the prefers-reduced-motion CSS @media-query.

Resolves #4348

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Jun 10, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jun 10, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner June 10, 2025 14:41
@mfranzke mfranzke added the 🧪test Improvements/bugs for testing-framework label Jun 10, 2025
@mfranzke mfranzke linked an issue Jun 10, 2025 that may be closed by this pull request
Let's rethink animations in automatic regression testing context #4348
Open
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Jun 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/4348-lets-rethink-animations-in-automatic-regression-testing-context

@mfranzke mfranzke closed this Jun 30, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In development to ✅ Done in UX Engineering Team Backlog Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget

Assignees

@mfranzke mfranzke

Labels
🍄🆙improvement New feature or request 🧪test Improvements/bugs for testing-framework
Projects
UX Engineering Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's rethink animations in automatic regression testing context
2 participants
@mfranzke @nmerget