fix(button): Prevent duplicate click events across frameworks while preserving native behaviour #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-button-click-double-call |
…reserving native behavior
michaelmkraus
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the duplicate click events issue by refactoring the button component click handler to use the useTarget utility for framework-specific event handling, and updates the Angular configuration to reflect new experimental outputs settings for the click event.
- Updated the button component to use a spread from useTarget for handling onClick events in a framework-agnostic manner.
- Modified the Angular configuration to apply an experimental outputs mapping for 'click'.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/src/components/button/button.lite.tsx | Refactored onClick handling using useTarget to prevent duplicate click events |
| packages/components/configs/angular/mitosis.config.cjs | Updated Angular config to include experimental outputs for click event mapping |
Comments suppressed due to low confidence (2)
packages/components/src/components/button/button.lite.tsx:55
- [nitpick] Consider adding an inline comment explaining the purpose of using useTarget for handling click events to aid future maintainers in understanding the framework-specific logic.
{...useTarget({
packages/components/configs/angular/mitosis.config.cjs:9
- [nitpick] Add a comment to explain the experimental outputs configuration and its intent to map the 'click' event, which will help clarify future updates or troubleshooting.
angular: {
nmerget
reviewed
Jun 18, 2025
| @@ -7,6 +6,12 @@ module.exports = { | |||
| targets: ['angular'], | |||
| dest: '../../output/tmp', | |||
| options: { | |||
| angular | |||
| angular: { | |||
| experimental: { | |||
There was a problem hiding this comment.
@michaelmkraus you removed the settings for signals api with this :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
closes #4339