[SRM] Add APIs to get the AssemblyNameInfo of an assembly definition or reference.
#116839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new APIs to obtain an AssemblyNameInfo instance from both assembly definitions and assembly references, complementing the existing GetAssemblyName API. The changes include implementation updates in the core libraries and corresponding tests validating the new API behavior.
- Adds GetAssemblyNameInfo methods to AssemblyReference and AssemblyDefinition.
- Enhances MetadataReader to construct AssemblyNameInfo from metadata.
- Updates tests in AssemblyDefinitionTests.cs to validate AssemblyNameInfo properties.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Reflection.Metadata/tests/Metadata/TypeSystem/AssemblyDefinitionTests.cs | Adds tests validating AssemblyNameInfo for both definitions and references. |
| src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeSystem/AssemblyReference.netstandard.cs | Introduces GetAssemblyNameInfo API for assembly references with proper XML documentation. |
| src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeSystem/AssemblyDefinition.netstandard.cs | Introduces GetAssemblyNameInfo API for assembly definitions with proper flag handling. |
| src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/MetadataReader.netstandard.cs | Adds a new method to create AssemblyNameInfo from metadata components. |
| src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/AssemblyNameInfo.cs | Updates using directives to include System.IO as part of AssemblyNameInfo. |
| src/libraries/System.Reflection.Metadata/ref/System.Reflection.Metadata.cs | Updates the reference assemblies to include the new GetAssemblyNameInfo API. |
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
teo-tsirpanis
force-pushed
the
srm-assembly-name-info
branch
from
c116db0 to
7bb24e6
Compare
This was referenced Jun 20, 2025
teo-tsirpanis
commented
Jun 20, 2025
src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/AssemblyNameInfo.cs
Outdated
Show resolved
Hide resolved
…/Metadata/AssemblyNameInfo.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113749.