Arm64 SVE: Fix conditionalselect with constant arguments #116852
+307
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#116847 When folding, allow arg1 to be a constant mask
|
@dotnet/arm64-contrib @kunalspathak |
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
/azp run Antigen, Fuzzlyn |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| } | ||
|
|
||
| #if defined(TARGET_XARCH) | ||
| case TYP_SIMD32: |
There was a problem hiding this comment.
so we are just adding this even though xarch is not exercising this path?
| { | ||
| switch (gtType) | ||
| { | ||
| case TYP_SIMD8: |
There was a problem hiding this comment.
I don't see why we would come in TYP_SIMD8 and TYP_SIMD16 for Mask constants?
| // depending on if the corresponding input element | ||
| // has its least significant bit set | ||
|
|
||
| bool isSet = static_cast<uint64_t>(1) << (i * sizeof(TBase)); |
There was a problem hiding this comment.
wait, we should be check isSet with content of input0, right?
| // depending on if the corresponding input element | ||
| // has its least significant bit set | ||
|
|
||
| bool isSet = static_cast<uint64_t>(1) << (i * sizeof(TBase)); |
kunalspathak
requested changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116847
When folding, allow arg1 to be a constant mask