Skip to content

balloon: Derive Debug for Balloon #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Jul 7, 2025

Changes

Derive Debug implementation for struct Balloon

Reason

The PR (https://github.com/main--/rust-timerfd/pull/12) that we were blocked on was merged a while ago.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ ] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [ ] I have mentioned all user-facing changes in CHANGELOG.md.
  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

The PR (https://github.com/main--/rust-timerfd/pull/12) was merged a
while ago.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@roypat roypat enabled auto-merge (rebase) July 7, 2025 11:06
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (a1a4a42) to head (e2f237b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5292      +/-   ##
==========================================
+ Coverage   82.86%   82.96%   +0.10%     
==========================================
  Files         250      250              
  Lines       26897    26880      -17     
==========================================
+ Hits        22288    22302      +14     
+ Misses       4609     4578      -31     
Flag Coverage Δ
5.10-c5n.metal 83.41% <ø> (+0.05%) ⬆️
5.10-m5n.metal 83.41% <ø> (+0.07%) ⬆️
5.10-m6a.metal 82.63% <ø> (+0.06%) ⬆️
5.10-m6g.metal 79.23% <ø> (+0.05%) ⬆️
5.10-m6i.metal 83.41% <ø> (+0.06%) ⬆️
5.10-m7a.metal-48xl 82.61% <ø> (?)
5.10-m7g.metal 79.23% <ø> (+0.05%) ⬆️
5.10-m7i.metal-24xl 83.37% <ø> (?)
5.10-m7i.metal-48xl 83.37% <ø> (?)
5.10-m8g.metal-24xl 79.23% <ø> (?)
5.10-m8g.metal-48xl 79.23% <ø> (?)
6.1-c5n.metal 83.45% <ø> (+0.06%) ⬆️
6.1-m5n.metal 83.46% <ø> (+0.05%) ⬆️
6.1-m6a.metal 82.67% <ø> (+0.06%) ⬆️
6.1-m6g.metal 79.23% <ø> (+0.06%) ⬆️
6.1-m6i.metal 83.45% <ø> (+0.06%) ⬆️
6.1-m7a.metal-48xl 82.66% <ø> (?)
6.1-m7g.metal 79.23% <ø> (+0.05%) ⬆️
6.1-m7i.metal-24xl 83.47% <ø> (?)
6.1-m7i.metal-48xl 83.47% <ø> (?)
6.1-m8g.metal-24xl 79.23% <ø> (?)
6.1-m8g.metal-48xl 79.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jul 7, 2025
Copy link
Contributor

@Manciukic Manciukic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

                __/___            
          _____/______|           
  _______/_____\_______\_____     
  \              < < <       |    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@roypat roypat merged commit bccb658 into firecracker-microvm:main Jul 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants