Skip to content

Improve JSON validation in start-proxy action #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025

Conversation

mbg
Copy link
Member

@mbg mbg commented Jun 27, 2025

This PR makes three changes related to the start-proxy action:

  1. Additional validation is performed on the structure of the parsed JSON, to ensure that we have an array of configurations, configurations themselves are objects, and we don't accidentally treat null values as meaningful.
  2. The test coverage is extended for these changes.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@mbg mbg force-pushed the mbg/start-proxy/validation-improvements branch from 28fe65c to 9281048 Compare July 2, 2025 16:03
@mbg mbg marked this pull request as ready for review July 3, 2025 09:07
@mbg mbg requested a review from a team as a code owner July 3, 2025 09:07
@mbg mbg merged commit b694213 into main Jul 3, 2025
572 of 573 checks passed
@mbg mbg deleted the mbg/start-proxy/validation-improvements branch July 3, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants