Skip to content

Add rust-toolchain ecosystem support #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@Copilot Copilot AI review requested due to automatic review settings June 24, 2025 18:15
@JamieMagee JamieMagee requested a review from a team as a code owner June 24, 2025 18:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the Rust toolchain ecosystem by wiring up a new container image in the update script, the registry metadata, and providing a stub Dockerfile.

  • Introduce rust_toolchain in the container manifest.
  • Update containers.json with a placeholder for the new image tag.
  • Add Dockerfile.rust-toolchain pointing at the new image.

Reviewed Changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated 2 comments.

File Description
src/update-containers.ts Added rust_toolchain entry to the manifest object.
docker/containers.json Inserted rust_toolchain key with a TODO tag.
docker/Dockerfile.rust-toolchain Created stub Dockerfile referencing the new image.
Comments suppressed due to low confidence (1)

src/update-containers.ts:47

  • [nitpick] There are no tests verifying that the new rust_toolchain key is correctly handled by update-containers.ts. Adding or updating a unit test to cover this new manifest entry would help prevent regressions.
  rust_toolchain: getImageName('Dockerfile.rust-toolchain')

@@ -22,5 +22,6 @@
"bun": "ghcr.io/dependabot/dependabot-updater-bun:v2.0.20250606230616@sha256:3f397ff4c064dc241a4cd17c66aa2d143fcf5a6d0a7954f34516082a6f87629b",
"docker_compose": "ghcr.io/dependabot/dependabot-updater-docker-compose:v2.0.20250606230616@sha256:6ae0447f216f00b673510fd2d11f79f8a36ed3c7e160f5525b3efc1304bc6217",
"uv": "ghcr.io/dependabot/dependabot-updater-uv:v2.0.20250606230616@sha256:6edb61a20817fa6e1bdfda51173f8ad7323a91ab0ac72345384af2c23c6b5aff",
"helm": "ghcr.io/dependabot/dependabot-updater-helm:v2.0.20250606230616@sha256:a6eadb370b009a3e74c3dd08fb57b46c9f0d0de39ea032dcc49973d8bbd80436"
"helm": "ghcr.io/dependabot/dependabot-updater-helm:v2.0.20250606230616@sha256:a6eadb370b009a3e74c3dd08fb57b46c9f0d0de39ea032dcc49973d8bbd80436",
"rust_toolchain": "ghcr.io/dependabot/dependabot-updater-rust-toolchain:TODO"
Copy link
Preview

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO placeholder needs to be replaced with the actual image tag and SHA once the Rust toolchain image is published, otherwise CI and deployments will pull an invalid reference.

Suggested change
"rust_toolchain": "ghcr.io/dependabot/dependabot-updater-rust-toolchain:TODO"
"rust_toolchain": "ghcr.io/dependabot/dependabot-updater-rust-toolchain:v2.0.20250606230616@sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"

Copilot uses AI. Check for mistakes.

@@ -0,0 +1 @@
FROM ghcr.io/dependabot/dependabot-updater-rust-toolchain:TODO
Copy link
Preview

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider parameterizing the version (e.g., via an ARG or environment variable) or updating this line with the real base image tag to avoid leaving a magic TODO value in the Dockerfile.

Suggested change
FROM ghcr.io/dependabot/dependabot-updater-rust-toolchain:TODO
ARG RUST_TOOLCHAIN_VERSION=latest
FROM ghcr.io/dependabot/dependabot-updater-rust-toolchain:${RUST_TOOLCHAIN_VERSION}

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant