Fix for code scanning alert no. 984: Call to System.IO.Path.Combine #1390
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Combine Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
….Combine Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two security vulnerabilities (alerts #984 and #983) by replacing Path.Combine calls with Path.Join to mitigate potential security risks. The change follows security best practices by using the safer Path.Join method which is not susceptible to the same vulnerabilities as Path.Combine.
Key changes:
- Updated path construction in CLI extension detection logic
- Modified test helper path generation for temporary repositories
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ado2gh/Program.cs | Updates extension path validation to use Path.Join instead of Path.Combine |
| src/OctoshiftCLI.IntegrationTests/TestHelper.cs | Changes temporary repository path creation to use Path.Join |
dylan-smith
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Unit Test Results 1 files 1 suites 20s ⏱️ Results for commit 6a3e12f. |
|
begonaguereca
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/github/gh-gei/security/code-scanning/984 and https://github.com/github/gh-gei/security/code-scanning/983
Path.CombineandPath.Joindo effectively the same thing, butPath.Combineis susceptible to a potential security vulnerability whereasPath.Joinis not. So the best practice is to always usePath.Join.This should resolve the last 2 outstanding security isseus flagged in this repo.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.