[BOLT] Set nfc-tests once #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an example to this:
This patch will add them once, under the NFC-mode condition. After #142410 is merged, those tests won't run. |
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/gnu-buildid-and-cleanup
branch
from
cdd7fc9 to
cf41ec9
Compare
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/set-nfc-tests-once
branch
from
b03cc23 to
9ffb74e
Compare
gkistanova
requested changes
Jun 17, 2025
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/set-nfc-tests-once
branch
from
9ffb74e to
154a315
Compare
paschalis-mpeis
changed the base branch from
users/paschalis-mpeis/gnu-buildid-and-cleanup
to
users/paschalis-mpeis/addninjasteps-none-checks
|
Thanks Galina for approving #477. I now assume there are no objections on your end on this PR. |
aaupov
reviewed
Jun 20, 2025
When setting up the nfc-mode tests, avoid adding an extra pair of in-tree and out-of-tree tests that were unconditional. This was previously done with addNinjaSteps. Instead, add those later and make them conditional on llvm-bolt being modified. Since tests are now only added by BOLTBuilder: - `ninja` runs the in-tree tests to correctly build dependencies. - flunkOnFailure is set to update the build status on failures. Some nits: - the '--switch-back' flag is used (from nfc-check-setup.py). - a 'nfc-' prefix is appended to 'check-bolt-different' step - remove timing.log cleanup
paschalis-mpeis
force-pushed
the
users/paschalis-mpeis/set-nfc-tests-once
branch
from
154a315 to
ff25d5c
Compare
paschalis-mpeis
changed the base branch from
users/paschalis-mpeis/addninjasteps-none-checks
to
main
|
Everything before this is now merged, so I've forced-pushed and rebased to main. |
aaupov
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the nfc-mode tests, avoid adding an extra pair of in-tree and
out-of-tree tests that were unconditional. This was previously done with
addNinjaSteps. Instead, add those later and make them conditional on llvm-bolt
being modified.
Since tests are now only added by BOLTBuilder:
ninjaruns the in-tree tests to correctly build dependencies.Some nits: