Skip to content

fix: quota validation error fixed #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request introduces significant enhancements to the quota validation scripts (validate_model_quota.ps1 and validate_model_quota.sh) for better usability, error handling, and user guidance. Key changes include improved messaging, input validation, fallback region handling, and a more robust flow for manual user input.

Improvements to user messaging and feedback:

  • Enhanced error and warning messages in validate_model_quota.ps1 and validate_model_quota.sh to provide clearer context, such as displaying available and required quotas ($PrimaryResult.Available, $Capacity) and recommended regions when capacity is below the threshold. [1] [2]

Enhanced fallback region handling:

  • Introduced a check_fallback_regions function in validate_model_quota.sh to streamline the process of identifying and suggesting fallback regions with sufficient quota. This function also displays a table of fallback regions and their quota details. [1] [2]

Improved input validation and user guidance:

  • Added checks for minimum recommended capacity (e.g., RECOMMENDED_TOKENS=200) in both scripts, warning users about potential performance issues if the entered capacity is too low, and prompting for confirmation to proceed. [1] [2]
  • Reorganized input validation logic in validate_model_quota.sh to ensure all required parameters are provided and valid before proceeding.

Refactoring and code organization:

  • Consolidated redundant logic in validate_model_quota.sh by introducing helper functions like show_table and manual_region_input for better modularity and readability. [1] [2]
  • Removed unused or redundant code blocks, such as outdated input validation and fallback handling logic, to simplify the scripts.

Additional minor updates:

  • Updated comments and formatting for better clarity and consistency across both scripts. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants